From: patchwork-bot+netdevbpf@kernel.org
To: Vasyl Vavrychuk <vasyl.vavrychuk@opensynergy.com>
Cc: linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
linux-bluetooth@vger.kernel.org, max.oss.09@gmail.com,
francesco.dolcini@toradex.com, mat.jonczyk@o2.pl,
kuba@kernel.org, marcel@holtmann.org,
max.krummenacher@toradex.com, johan.hedberg@gmail.com,
luiz.dentz@gmail.com, davem@davemloft.net, pabeni@redhat.com,
edumazet@google.com
Subject: Re: [PATCH] Bluetooth: core: Fix deadlock due to `cancel_work_sync(&hdev->power_on)` from hci_power_on_sync.
Date: Tue, 05 Jul 2022 21:50:13 +0000 [thread overview]
Message-ID: <165705781323.1977.3304816866885746199.git-patchwork-notify@kernel.org> (raw)
In-Reply-To: <20220705125931.3601-1-vasyl.vavrychuk@opensynergy.com>
Hello:
This patch was applied to netdev/net.git (master)
by Luiz Augusto von Dentz <luiz.von.dentz@intel.com>:
On Tue, 5 Jul 2022 15:59:31 +0300 you wrote:
> `cancel_work_sync(&hdev->power_on)` was moved to hci_dev_close_sync in
> commit [1] to ensure that power_on work is canceled after HCI interface
> down.
>
> But, in certain cases power_on work function may call hci_dev_close_sync
> itself: hci_power_on -> hci_dev_do_close -> hci_dev_close_sync ->
> cancel_work_sync(&hdev->power_on), causing deadlock. In particular, this
> happens when device is rfkilled on boot. To avoid deadlock, move
> power_on work canceling out of hci_dev_do_close/hci_dev_close_sync.
>
> [...]
Here is the summary with links:
- Bluetooth: core: Fix deadlock due to `cancel_work_sync(&hdev->power_on)` from hci_power_on_sync.
https://git.kernel.org/netdev/net/c/e36bea6e78ab
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
prev parent reply other threads:[~2022-07-05 21:50 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-14 18:17 [PATCH v1] Revert "Bluetooth: core: Fix missing power_on work cancel on HCI close" Max Krummenacher
2022-06-14 18:53 ` [v1] " bluez.test.bot
2022-06-21 11:55 ` [PATCH v1] " Francesco Dolcini
2022-06-23 19:51 ` Jakub Kicinski
2022-07-04 19:56 ` Mateusz Jończyk
2022-07-05 14:09 ` Max Krummenacher
2022-07-05 12:59 ` [PATCH] Bluetooth: core: Fix deadlock due to `cancel_work_sync(&hdev->power_on)` from hci_power_on_sync Vasyl Vavrychuk
2022-07-05 14:12 ` Max Krummenacher
2022-07-05 14:13 ` bluez.test.bot
2022-07-05 15:14 ` [PATCH] " Francesco Dolcini
2022-07-05 17:26 ` Luiz Augusto von Dentz
2022-07-05 18:38 ` Jakub Kicinski
2022-07-05 19:00 ` Luiz Augusto von Dentz
2022-07-05 19:13 ` Jakub Kicinski
2022-07-05 18:38 ` Mateusz Jończyk
2022-07-05 21:50 ` patchwork-bot+netdevbpf [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=165705781323.1977.3304816866885746199.git-patchwork-notify@kernel.org \
--to=patchwork-bot+netdevbpf@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=francesco.dolcini@toradex.com \
--cc=johan.hedberg@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-bluetooth@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luiz.dentz@gmail.com \
--cc=marcel@holtmann.org \
--cc=mat.jonczyk@o2.pl \
--cc=max.krummenacher@toradex.com \
--cc=max.oss.09@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=vasyl.vavrychuk@opensynergy.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.