From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: Tony Battersby <tonyb@cybernetics.com>,
Doug Gilbert <dgilbert@interlog.com>,
"James E.J. Bottomley" <jejb@linux.ibm.com>
Cc: "Martin K . Petersen" <martin.petersen@oracle.com>,
linux-scsi <linux-scsi@vger.kernel.org>
Subject: Re: [PATCH RESEND] sg: allow waiting for commands to complete on removed device
Date: Mon, 18 Jul 2022 23:09:00 -0400 [thread overview]
Message-ID: <165820009735.29375.16679071052940876274.b4-ty@oracle.com> (raw)
In-Reply-To: <5ebea46f-fe83-2d0b-233d-d0dcb362dd0a@cybernetics.com>
On Mon, 11 Jul 2022 10:51:32 -0400, Tony Battersby wrote:
> When a SCSI device is removed while in active use, currently sg will
> immediately return -ENODEV on any attempt to wait for active commands
> that were sent before the removal. This is problematic for commands
> that use SG_FLAG_DIRECT_IO since the data buffer may still be in use by
> the kernel when userspace frees or reuses it after getting ENODEV,
> leading to corrupted userspace memory (in the case of READ-type
> commands) or corrupted data being sent to the device (in the case of
> WRITE-type commands). This has been seen in practice when logging out
> of a iscsi_tcp session, where the iSCSI driver may still be processing
> commands after the device has been marked for removal.
>
> [...]
Applied to 5.20/scsi-queue, thanks!
[1/1] sg: allow waiting for commands to complete on removed device
https://git.kernel.org/mkp/scsi/c/3455607fd7be
--
Martin K. Petersen Oracle Linux Engineering
prev parent reply other threads:[~2022-07-19 3:09 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-11 14:51 [PATCH RESEND] sg: allow waiting for commands to complete on removed device Tony Battersby
2022-07-11 19:37 ` Douglas Gilbert
2022-07-14 3:51 ` Martin K. Petersen
2022-07-19 3:09 ` Martin K. Petersen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=165820009735.29375.16679071052940876274.b4-ty@oracle.com \
--to=martin.petersen@oracle.com \
--cc=dgilbert@interlog.com \
--cc=jejb@linux.ibm.com \
--cc=linux-scsi@vger.kernel.org \
--cc=tonyb@cybernetics.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.