From: Chuck Lever <chuck.lever@oracle.com>
To: anna.schumaker@netapp.com, trondmy@hammerspace.com
Cc: linux-nfs@vger.kernel.org
Subject: [PATCH v2 1/4] SUNRPC: Fail faster on bad verifier
Date: Fri, 22 Jul 2022 15:08:04 -0400 [thread overview]
Message-ID: <165851688478.2312015.9119100251679837612.stgit@morisot.1015granger.net> (raw)
In-Reply-To: <165851677341.2312015.16636288284789960852.stgit@morisot.1015granger.net>
A bad verifier is not a garbage argument, it's an authentication
failure. Retrying it doesn't make the problem go away, and delays
upper layer recovery steps.
Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
Reviewed-by: Jeff Layton <jlayton@kernel.org>
Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
---
net/sunrpc/clnt.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/sunrpc/clnt.c b/net/sunrpc/clnt.c
index b6781ada3aa8..a97d4e06cae3 100644
--- a/net/sunrpc/clnt.c
+++ b/net/sunrpc/clnt.c
@@ -2650,7 +2650,7 @@ rpc_decode_header(struct rpc_task *task, struct xdr_stream *xdr)
out_verifier:
trace_rpc_bad_verifier(task);
- goto out_garbage;
+ goto out_err;
out_msg_denied:
error = -EACCES;
next prev parent reply other threads:[~2022-07-22 19:08 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-22 19:07 [PATCH v2 0/4] Pre-requisites for client-side RPC-with-TLS support Chuck Lever
2022-07-22 19:08 ` Chuck Lever [this message]
2022-07-22 19:08 ` [PATCH v2 2/4] SUNRPC: Widen rpc_task::tk_flags Chuck Lever
2022-07-22 19:08 ` [PATCH v2 3/4] SUNRPC: Replace dprintk() call site in xs_data_ready Chuck Lever
2022-07-25 14:03 ` Jeff Layton
2022-07-22 19:08 ` [PATCH v2 4/4] NFS: Replace fs_context-related dprintk() call sites with tracepoints Chuck Lever
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=165851688478.2312015.9119100251679837612.stgit@morisot.1015granger.net \
--to=chuck.lever@oracle.com \
--cc=anna.schumaker@netapp.com \
--cc=linux-nfs@vger.kernel.org \
--cc=trondmy@hammerspace.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.