All of lore.kernel.org
 help / color / mirror / Atom feed
From: Chuck Lever <chuck.lever@oracle.com>
To: linux-nfs@vger.kernel.org
Subject: [PATCH v2 05/13] NFSD: Reorder the fields in struct nfsd4_op
Date: Wed, 27 Jul 2022 14:40:28 -0400	[thread overview]
Message-ID: <165894722875.11193.2238058528803056154.stgit@manet.1015granger.net> (raw)
In-Reply-To: <165894669884.11193.6386905165076468843.stgit@manet.1015granger.net>

Pack the fields to reduce the size of struct nfsd4_op, which is used
an array in struct nfsd4_compoundargs.

sizeof(struct nfsd4_op):
Before: /* size: 672, cachelines: 11, members: 5 */
After:  /* size: 640, cachelines: 10, members: 5 */

Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
---
 fs/nfsd/xdr4.h |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/fs/nfsd/xdr4.h b/fs/nfsd/xdr4.h
index f5ad2939e6ee..a36678e3ca0e 100644
--- a/fs/nfsd/xdr4.h
+++ b/fs/nfsd/xdr4.h
@@ -606,8 +606,9 @@ struct nfsd4_copy_notify {
 
 struct nfsd4_op {
 	u32					opnum;
-	const struct nfsd4_operation *		opdesc;
 	__be32					status;
+	const struct nfsd4_operation		*opdesc;
+	struct nfs4_replay			*replay;
 	union nfsd4_op_u {
 		struct nfsd4_access		access;
 		struct nfsd4_close		close;
@@ -671,7 +672,6 @@ struct nfsd4_op {
 		struct nfsd4_listxattrs		listxattrs;
 		struct nfsd4_removexattr	removexattr;
 	} u;
-	struct nfs4_replay *			replay;
 };
 
 bool nfsd4_cache_this_op(struct nfsd4_op *);



  parent reply	other threads:[~2022-07-27 19:07 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-07-27 18:39 [PATCH v2 00/13] Put struct nfsd4_copy on a diet Chuck Lever
2022-07-27 18:40 ` [PATCH v2 01/13] NFSD: Fix strncpy() fortify warning Chuck Lever
2022-07-27 18:40 ` [PATCH v2 02/13] NFSD: nfserrno(-ENOMEM) is nfserr_jukebox Chuck Lever
2022-07-27 18:40 ` [PATCH v2 03/13] NFSD: Shrink size of struct nfsd4_copy_notify Chuck Lever
2022-07-27 18:40 ` [PATCH v2 04/13] NFSD: Shrink size of struct nfsd4_copy Chuck Lever
2022-07-27 18:40 ` Chuck Lever [this message]
2022-07-27 18:40 ` [PATCH v2 06/13] NFSD: Make nfs4_put_copy() static Chuck Lever
2022-07-27 18:40 ` [PATCH v2 07/13] NFSD: Make boolean fields in struct nfsd4_copy into atomic bit flags Chuck Lever
2022-07-27 18:40 ` [PATCH v2 08/13] NFSD: Refactor nfsd4_cleanup_inter_ssc() (1/2) Chuck Lever
2022-07-27 18:40 ` [PATCH v2 09/13] NFSD: Refactor nfsd4_cleanup_inter_ssc() (2/2) Chuck Lever
2022-07-27 18:40 ` [PATCH v2 10/13] NFSD: Refactor nfsd4_do_copy() Chuck Lever
2022-07-27 18:41 ` [PATCH v2 11/13] NFSD: Remove kmalloc from nfsd4_do_async_copy() Chuck Lever
2022-07-27 18:41 ` [PATCH v2 12/13] NFSD: Add nfsd4_send_cb_offload() Chuck Lever
2022-07-27 18:41 ` [PATCH v2 13/13] NFSD: Move copy offload callback arguments into a separate structure Chuck Lever

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=165894722875.11193.2238058528803056154.stgit@manet.1015granger.net \
    --to=chuck.lever@oracle.com \
    --cc=linux-nfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.