Re: [PATCH 2/2] wifi: mac80211: add LDPC related flags in ieee80211_bss_conf

From: Johannes Berg <johannes@sipsolutions.net>
To: Ryder Lee <ryder.lee@mediatek.com>, linux-wireless@vger.kernel.org
Cc: Shayne Chen <shayne.chen@mediatek.com>,
	Evelyn Tsai <evelyn.tsai@mediatek.com>,
	linux-mediatek@lists.infradead.org
Subject: Re: [PATCH 2/2] wifi: mac80211: add LDPC related flags in ieee80211_bss_conf
Date: Wed, 15 Feb 2023 18:43:10 +0100	[thread overview]
Message-ID: <165dcb98f58e8d6049d89d8e4ebb326b8fe631b8.camel@sipsolutions.net> (raw)
In-Reply-To: <4e5cff1c538cbd9ecca171e0e4d6fddd87c3dfa0.1675893838.git.ryder.lee@mediatek.com>

On Thu, 2023-02-09 at 06:09 +0800, Ryder Lee wrote:
> This is utilized to pass LDPC configurations from user space (i.e. hostap) to driver.

again, hostapd

why do we need this?

> + * @ht_ldpc: in AP mode, indicates interface owns HT LDPC capability.
> + * @vht_ldpc: in AP mode, indicates interface owns VHT LDPC capability.
> + * @he_ldpc: in AP mode, indicates interface owns HE LDPC capability.

what do you mean by "owns" the capability? Has? Uses it?

> diff --git a/net/mac80211/cfg.c b/net/mac80211/cfg.c
> index 6bf1cdf254f6..a080010da8fb 100644
> --- a/net/mac80211/cfg.c
> +++ b/net/mac80211/cfg.c
> @@ -1252,7 +1252,16 @@ static int ieee80211_start_ap(struct wiphy *wiphy, struct net_device *dev,
>  	prev_beacon_int = link_conf->beacon_int;
>  	link_conf->beacon_int = params->beacon_interval;
>  
> +	if (params->ht_cap) {
> +		link_conf->ht_ldpc =
> +			params->ht_cap->cap_info &
> +				cpu_to_le16(IEEE80211_HT_CAP_LDPC_CODING);
> +	}

No need for braces.

johannes