From: patchwork-bot+netdevbpf@kernel.org
To: Thadeu Lima de Souza Cascardo <cascardo@canonical.com>
Cc: netdev@vger.kernel.org, jhs@mojatatu.com,
xiyou.wangcong@gmail.com, jiri@resnulli.us,
zplin@u.northwestern.edu, kamal@canonical.com,
stable@vger.kernel.org
Subject: Re: [PATCH] net_sched: cls_route: remove from list when handle is 0
Date: Thu, 11 Aug 2022 06:10:14 +0000 [thread overview]
Message-ID: <166019821453.2125.16900691983468288417.git-patchwork-notify@kernel.org> (raw)
In-Reply-To: <20220809170518.164662-1-cascardo@canonical.com>
Hello:
This patch was applied to netdev/net.git (master)
by Jakub Kicinski <kuba@kernel.org>:
On Tue, 9 Aug 2022 14:05:18 -0300 you wrote:
> When a route filter is replaced and the old filter has a 0 handle, the old
> one won't be removed from the hashtable, while it will still be freed.
>
> The test was there since before commit 1109c00547fc ("net: sched: RCU
> cls_route"), when a new filter was not allocated when there was an old one.
> The old filter was reused and the reinserting would only be necessary if an
> old filter was replaced. That was still wrong for the same case where the
> old handle was 0.
>
> [...]
Here is the summary with links:
- net_sched: cls_route: remove from list when handle is 0
https://git.kernel.org/netdev/net/c/9ad36309e271
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
prev parent reply other threads:[~2022-08-11 6:10 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-09 17:05 [PATCH] net_sched: cls_route: remove from list when handle is 0 Thadeu Lima de Souza Cascardo
2022-08-09 19:11 ` Jamal Hadi Salim
2022-08-11 6:10 ` patchwork-bot+netdevbpf [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=166019821453.2125.16900691983468288417.git-patchwork-notify@kernel.org \
--to=patchwork-bot+netdevbpf@kernel.org \
--cc=cascardo@canonical.com \
--cc=jhs@mojatatu.com \
--cc=jiri@resnulli.us \
--cc=kamal@canonical.com \
--cc=netdev@vger.kernel.org \
--cc=stable@vger.kernel.org \
--cc=xiyou.wangcong@gmail.com \
--cc=zplin@u.northwestern.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.