From: Will Deacon <will@kernel.org>
To: Sergey Shtylyov <s.shtylyov@omp.ru>,
linux-arm-kernel@lists.infradead.org,
Catalin Marinas <catalin.marinas@arm.com>
Cc: kernel-team@android.com, Will Deacon <will@kernel.org>,
lvc-project@linuxtesting.org
Subject: Re: [PATCH] arm64: topology: fix possible overflow in amu_fie_setup()
Date: Thu, 22 Sep 2022 13:45:40 +0100 [thread overview]
Message-ID: <166384782764.3353565.7066075154893041437.b4-ty@kernel.org> (raw)
In-Reply-To: <01493d64-2bce-d968-86dc-11a122a9c07d@omp.ru>
On Fri, 16 Sep 2022 23:17:07 +0300, Sergey Shtylyov wrote:
> cpufreq_get_hw_max_freq() returns max frequency in kHz as *unsigned int*,
> while freq_inv_set_max_ratio() gets passed this frequency in Hz as 'u64'.
> Multiplying max frequency by 1000 can potentially result in overflow --
> multiplying by 1000ULL instead should avoid that...
>
> Found by Linux Verification Center (linuxtesting.org) with the SVACE static
> analysis tool.
>
> [...]
Applied to arm64 (for-next/fixes), thanks!
[1/1] arm64: topology: fix possible overflow in amu_fie_setup()
https://git.kernel.org/arm64/c/d4955c0ad77d
Cheers,
--
Will
https://fixes.arm64.dev
https://next.arm64.dev
https://will.arm64.dev
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
prev parent reply other threads:[~2022-09-22 12:47 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-16 20:17 [PATCH] arm64: topology: fix possible overflow in amu_fie_setup() Sergey Shtylyov
2022-09-22 12:45 ` Will Deacon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=166384782764.3353565.7066075154893041437.b4-ty@kernel.org \
--to=will@kernel.org \
--cc=catalin.marinas@arm.com \
--cc=kernel-team@android.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=lvc-project@linuxtesting.org \
--cc=s.shtylyov@omp.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.