From: patchwork-bot+netdevbpf@kernel.org
To: Jakub Sitnicki <jakub@cloudflare.com>
Cc: netdev@vger.kernel.org, davem@davemloft.net, edumazet@google.com,
kuba@kernel.org, pabeni@redhat.com, tparkin@katalix.com,
penguin-kernel@i-love.sakura.ne.jp,
syzbot+703d9e154b3b58277261@syzkaller.appspotmail.com,
syzbot+50680ced9e98a61f7698@syzkaller.appspotmail.com,
syzbot+de987172bb74a381879b@syzkaller.appspotmail.com
Subject: Re: [PATCH net v2] l2tp: Don't sleep and disable BH under writer-side sk_callback_lock
Date: Wed, 23 Nov 2022 12:50:15 +0000 [thread overview]
Message-ID: <166920781520.7047.5118959763745270461.git-patchwork-notify@kernel.org> (raw)
In-Reply-To: <20221121085426.21315-1-jakub@cloudflare.com>
Hello:
This patch was applied to netdev/net.git (master)
by David S. Miller <davem@davemloft.net>:
On Mon, 21 Nov 2022 09:54:26 +0100 you wrote:
> When holding a reader-writer spin lock we cannot sleep. Calling
> setup_udp_tunnel_sock() with write lock held violates this rule, because we
> end up calling percpu_down_read(), which might sleep, as syzbot reports
> [1]:
>
> __might_resched.cold+0x222/0x26b kernel/sched/core.c:9890
> percpu_down_read include/linux/percpu-rwsem.h:49 [inline]
> cpus_read_lock+0x1b/0x140 kernel/cpu.c:310
> static_key_slow_inc+0x12/0x20 kernel/jump_label.c:158
> udp_tunnel_encap_enable include/net/udp_tunnel.h:187 [inline]
> setup_udp_tunnel_sock+0x43d/0x550 net/ipv4/udp_tunnel_core.c:81
> l2tp_tunnel_register+0xc51/0x1210 net/l2tp/l2tp_core.c:1509
> pppol2tp_connect+0xcdc/0x1a10 net/l2tp/l2tp_ppp.c:723
>
> [...]
Here is the summary with links:
- [net,v2] l2tp: Don't sleep and disable BH under writer-side sk_callback_lock
https://git.kernel.org/netdev/net/c/af295e854a4e
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
prev parent reply other threads:[~2022-11-23 13:07 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-21 8:54 [PATCH net v2] l2tp: Don't sleep and disable BH under writer-side sk_callback_lock Jakub Sitnicki
2022-11-23 12:50 ` patchwork-bot+netdevbpf [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=166920781520.7047.5118959763745270461.git-patchwork-notify@kernel.org \
--to=patchwork-bot+netdevbpf@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=jakub@cloudflare.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=penguin-kernel@i-love.sakura.ne.jp \
--cc=syzbot+50680ced9e98a61f7698@syzkaller.appspotmail.com \
--cc=syzbot+703d9e154b3b58277261@syzkaller.appspotmail.com \
--cc=syzbot+de987172bb74a381879b@syzkaller.appspotmail.com \
--cc=tparkin@katalix.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.