From: Jens Axboe <axboe@kernel.dk>
To: Bart Van Assche <bvanassche@acm.org>
Cc: linux-block@vger.kernel.org, Eric Biggers <ebiggers@google.com>,
Christoph Hellwig <hch@lst.de>
Subject: Re: [PATCH] blk-crypto: Add a missing include directive
Date: Wed, 23 Nov 2022 10:39:11 -0700 [thread overview]
Message-ID: <166922515142.2606.472578798999047121.b4-ty@kernel.dk> (raw)
In-Reply-To: <20221123172923.434339-1-bvanassche@acm.org>
On Wed, 23 Nov 2022 09:29:23 -0800, Bart Van Assche wrote:
> Allow the compiler to verify consistency of function declarations and
> function definitions. This patch fixes the following sparse errors:
>
> block/blk-crypto-profile.c:241:14: error: no previous prototype for ‘blk_crypto_get_keyslot’ [-Werror=missing-prototypes]
> 241 | blk_status_t blk_crypto_get_keyslot(struct blk_crypto_profile *profile,
> | ^~~~~~~~~~~~~~~~~~~~~~
> block/blk-crypto-profile.c:318:6: error: no previous prototype for ‘blk_crypto_put_keyslot’ [-Werror=missing-prototypes]
> 318 | void blk_crypto_put_keyslot(struct blk_crypto_keyslot *slot)
> | ^~~~~~~~~~~~~~~~~~~~~~
> block/blk-crypto-profile.c:344:6: error: no previous prototype for ‘__blk_crypto_cfg_supported’ [-Werror=missing-prototypes]
> 344 | bool __blk_crypto_cfg_supported(struct blk_crypto_profile *profile,
> | ^~~~~~~~~~~~~~~~~~~~~~~~~~
> block/blk-crypto-profile.c:373:5: error: no previous prototype for ‘__blk_crypto_evict_key’ [-Werror=missing-prototypes]
> 373 | int __blk_crypto_evict_key(struct blk_crypto_profile *profile,
> | ^~~~~~~~~~~~~~~~~~~~~~
>
> [...]
Applied, thanks!
[1/1] blk-crypto: Add a missing include directive
commit: 85168d416e5d3184b77dbec8fee75c9439894afa
Best regards,
--
Jens Axboe
next prev parent reply other threads:[~2022-11-23 17:39 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-23 17:29 [PATCH] blk-crypto: Add a missing include directive Bart Van Assche
2022-11-23 17:39 ` Jens Axboe [this message]
2022-11-23 18:28 ` Eric Biggers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=166922515142.2606.472578798999047121.b4-ty@kernel.dk \
--to=axboe@kernel.dk \
--cc=bvanassche@acm.org \
--cc=ebiggers@google.com \
--cc=hch@lst.de \
--cc=linux-block@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.