All of lore.kernel.org
 help / color / mirror / Atom feed
From: "irqchip-bot for Jianmin Lv" <tip-bot2@linutronix.de>
To: linux-kernel@vger.kernel.org
Cc: Jianmin Lv <lvjianmin@loongson.cn>,
	Huacai Chen <chenhuacai@loongson.cn>,
	Marc Zyngier <maz@kernel.org>,
	tglx@linutronix.de
Subject: [irqchip: irq/irqchip-next] irqchip/loongson-pch-pic: Support to set IRQ type for ACPI path
Date: Sat, 26 Nov 2022 13:34:42 -0000	[thread overview]
Message-ID: <166946968274.4906.12418462636499559107.tip-bot2@tip-bot2> (raw)
In-Reply-To: <20221022075955.11726-4-lvjianmin@loongson.cn>

The following commit has been merged into the irq/irqchip-next branch of irqchip:

Commit-ID:     25f3514aab3748bfef4a279ed599f836ac83e62a
Gitweb:        https://git.kernel.org/pub/scm/linux/kernel/git/maz/arm-platforms/25f3514aab3748bfef4a279ed599f836ac83e62a
Author:        Jianmin Lv <lvjianmin@loongson.cn>
AuthorDate:    Sat, 22 Oct 2022 15:59:54 +08:00
Committer:     Marc Zyngier <maz@kernel.org>
CommitterDate: Sat, 26 Nov 2022 13:05:48 

irqchip/loongson-pch-pic: Support to set IRQ type for ACPI path

For ACPI path, the translate callback used IRQ_TYPE_NONE and ignored
the IRQ type in fwspec->param[1]. For supporting to set type for
IRQs of the irqdomain, fwspec->param[1] should be used to get IRQ
type.

Signed-off-by: Jianmin Lv <lvjianmin@loongson.cn>
Reviewed-by: Huacai Chen <chenhuacai@loongson.cn>
Signed-off-by: Marc Zyngier <maz@kernel.org>
Link: https://lore.kernel.org/r/20221022075955.11726-4-lvjianmin@loongson.cn
---
 drivers/irqchip/irq-loongson-pch-pic.c | 11 +++++++----
 1 file changed, 7 insertions(+), 4 deletions(-)

diff --git a/drivers/irqchip/irq-loongson-pch-pic.c b/drivers/irqchip/irq-loongson-pch-pic.c
index 03493cd..a26a3f5 100644
--- a/drivers/irqchip/irq-loongson-pch-pic.c
+++ b/drivers/irqchip/irq-loongson-pch-pic.c
@@ -155,9 +155,6 @@ static int pch_pic_domain_translate(struct irq_domain *d,
 	struct pch_pic *priv = d->host_data;
 	struct device_node *of_node = to_of_node(fwspec->fwnode);
 
-	if (fwspec->param_count < 1)
-		return -EINVAL;
-
 	if (of_node) {
 		if (fwspec->param_count < 2)
 			return -EINVAL;
@@ -165,8 +162,14 @@ static int pch_pic_domain_translate(struct irq_domain *d,
 		*hwirq = fwspec->param[0] + priv->ht_vec_base;
 		*type = fwspec->param[1] & IRQ_TYPE_SENSE_MASK;
 	} else {
+		if (fwspec->param_count < 1)
+			return -EINVAL;
+
 		*hwirq = fwspec->param[0] - priv->gsi_base;
-		*type = IRQ_TYPE_NONE;
+		if (fwspec->param_count > 1)
+			*type = fwspec->param[1] & IRQ_TYPE_SENSE_MASK;
+		else
+			*type = IRQ_TYPE_NONE;
 	}
 
 	return 0;

  reply	other threads:[~2022-11-26 13:35 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-22  7:59 [PATCH V5 0/4] irqchip: Support to set irq type for ACPI path Jianmin Lv
2022-10-22  7:59 ` [PATCH V5 1/4] ACPI / PCI: fix LPIC IRQ model default PCI IRQ polarity Jianmin Lv
2022-11-26 13:34   ` [irqchip: irq/irqchip-next] " irqchip-bot for Jianmin Lv
2022-10-22  7:59 ` [PATCH V5 2/4] irqchip/loongson-pch-pic: fix translate callback for DT path Jianmin Lv
2022-11-26 13:34   ` [irqchip: irq/irqchip-next] irqchip/loongson-pch-pic: Fix " irqchip-bot for Jianmin Lv
2022-10-22  7:59 ` [PATCH V5 3/4] irqchip/loongson-pch-pic: Support to set IRQ type for ACPI path Jianmin Lv
2022-11-26 13:34   ` irqchip-bot for Jianmin Lv [this message]
2022-10-22  7:59 ` [PATCH V5 4/4] irqchip/loongson-liointc: " Jianmin Lv
2022-11-26 13:34   ` [irqchip: irq/irqchip-next] " irqchip-bot for Jianmin Lv
2022-10-22  8:05 ` [PATCH V5 0/4] irqchip: Support to set irq " Huacai Chen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=166946968274.4906.12418462636499559107.tip-bot2@tip-bot2 \
    --to=tip-bot2@linutronix.de \
    --cc=chenhuacai@loongson.cn \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lvjianmin@loongson.cn \
    --cc=maz@kernel.org \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.