From: ~axelheider <axelheider@git.sr.ht>
To: qemu-devel@nongnu.org
Cc: qemu-arm@nongnu.org, peter.maydell@linaro.org
Subject: [PATCH qemu.git v3 0/8] hw/timer/imx_epit: improve and fix EPIT compare timer
Date: Thu, 01 Dec 2022 15:42:00 +0000 [thread overview]
Message-ID: <166990932074.29941.8709118178538288040-0@git.sr.ht> (raw)
This patch set improves the i.MX EPIT emulation:
- fix #1263 for writes to CR
- ensure SR_OCIF is set properly even if CR_OCIEN is off
- hardware reset initialized CR to 0
- interrupt state update on CR writes (e.g. software reset)
- remove explicit fields cnt and freq (they are redundant)
- general code and documentation improvements
v3 addresses the comments from the previous iterations, but still keeps
the scope of this patchset limited to addressing the obvious bugs in the
behavior. It does not try to improve the timer accuracy, thus the
following remarks remain to be fixed in a future patch after this one is
merged:
- don't use PTIMER_POLICY_LEGACY. Fine tuning this requires more
time and currently this is not a major concern, because the timer is
working reasonably well.
- replace the modestly harmful sequence
counter = ptimer_get_count(s->timer_reload);
...
ptimer_set_count(s->timer_cmp, counter);
by something better that does not lose or gain time. The current
patchset does not introduce this sequence, it has been there
before already. Again, the current lack of accuracy here is not a
major concern because the timer is working reasonably well.
Axel Heider (8):
hw/timer/imx_epit: improve comments
hw/timer/imx_epit: cleanup CR defines
hw/timer/imx_epit: define SR_OCIF
hw/timer/imx_epit: update interrupt state on CR write access
hw/timer/imx_epit: hard reset initializes CR with 0
hw/timer/imx_epit: factor out register write handlers
hw/timer/imx_epit: remove explicit fields cnt and freq
hw/timer/imx_epit: fix compare timer handling
hw/timer/imx_epit.c | 370 +++++++++++++++++++++---------------
include/hw/timer/imx_epit.h | 8 +-
2 files changed, 222 insertions(+), 156 deletions(-)
--
2.34.5
next reply other threads:[~2022-12-01 15:43 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-01 15:42 ~axelheider [this message]
2022-10-25 10:33 ` [PATCH qemu.git v3 7/8] hw/timer/imx_epit: remove explicit fields cnt and freq ~axelheider
2023-01-05 12:08 ` Peter Maydell
2022-10-25 15:33 ` [PATCH qemu.git v3 1/8] hw/timer/imx_epit: improve comments ~axelheider
2023-01-05 12:00 ` Peter Maydell
2022-10-25 18:32 ` [PATCH qemu.git v3 4/8] hw/timer/imx_epit: update interrupt state on CR write access ~axelheider
2023-01-05 12:03 ` Peter Maydell
2022-10-27 13:09 ` [PATCH qemu.git v3 6/8] hw/timer/imx_epit: factor out register write handlers ~axelheider
2023-01-05 12:04 ` Peter Maydell
2022-10-30 23:59 ` [PATCH qemu.git v3 2/8] hw/timer/imx_epit: cleanup CR defines ~axelheider
2023-01-05 12:00 ` Peter Maydell
2022-11-19 14:59 ` [PATCH qemu.git v3 3/8] hw/timer/imx_epit: define SR_OCIF ~axelheider
2023-01-05 12:01 ` Peter Maydell
2022-11-19 16:09 ` [PATCH qemu.git v3 5/8] hw/timer/imx_epit: hard reset initializes CR with 0 ~axelheider
2023-01-05 12:04 ` Peter Maydell
2022-11-20 19:05 ` [PATCH qemu.git v3 8/8] hw/timer/imx_epit: fix compare timer handling ~axelheider
2023-01-05 12:21 ` Peter Maydell
2023-01-05 21:08 ` Axel Heider
2023-04-04 15:44 ` Peter Maydell
2023-04-04 16:26 ` Axel Heider
2023-01-05 12:23 ` [PATCH qemu.git v3 0/8] hw/timer/imx_epit: improve and fix EPIT compare timer Peter Maydell
2023-01-05 21:11 ` Axel Heider
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=166990932074.29941.8709118178538288040-0@git.sr.ht \
--to=axelheider@git.sr.ht \
--cc=axelheider@gmx.de \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.