All of lore.kernel.org
 help / color / mirror / Atom feed
From: Chuck Lever <cel@kernel.org>
To: linux-nfs@vger.kernel.org
Subject: [PATCH v1 0/2] Switch SUNRPC server to per-CPU counters
Date: Tue, 10 Jan 2023 10:31:47 -0500	[thread overview]
Message-ID: <167336437322.15674.16325059932149395877.stgit@bazille.1015granger.net> (raw)

I'm trying to enable the use of KCSAN on NFSD. There are some false
positives that make the signal-to-noise ratio unfavorable.

The noisiest data races we (NFSD chickens) have direct control over
are the per-RPC and per-pool statistics. These two patches try to
address those.

There might be some additional desirable changes. For example, we
could make the RPC counters per-net. I'm saving up those pennies
for another rainy day.

---

Chuck Lever (2):
      SUNRPC: Use per-CPU counters to tally server RPC counts
      SUNRPC: Replace pool stats with per-CPU variables


 fs/lockd/svc.c              | 15 ++++++++++-----
 fs/nfs/callback_xdr.c       |  6 ++++--
 fs/nfsd/nfs2acl.c           |  5 +++--
 fs/nfsd/nfs3acl.c           |  5 +++--
 fs/nfsd/nfs3proc.c          |  5 +++--
 fs/nfsd/nfs4proc.c          |  7 ++++---
 fs/nfsd/nfsproc.c           |  6 +++---
 include/linux/lockd/lockd.h |  4 ++--
 include/linux/sunrpc/svc.h  | 17 +++++++----------
 net/sunrpc/stats.c          | 11 ++++++++---
 net/sunrpc/svc.c            | 14 +++++++++++++-
 net/sunrpc/svc_xprt.c       | 18 ++++++++----------
 12 files changed, 68 insertions(+), 45 deletions(-)

--
Chuck Lever


             reply	other threads:[~2023-01-10 15:33 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-10 15:31 Chuck Lever [this message]
2023-01-10 15:31 ` [PATCH v1 1/2] SUNRPC: Use per-CPU counters to tally server RPC counts Chuck Lever
2023-01-10 15:32 ` [PATCH v1 2/2] SUNRPC: Replace pool stats with per-CPU variables Chuck Lever

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=167336437322.15674.16325059932149395877.stgit@bazille.1015granger.net \
    --to=cel@kernel.org \
    --cc=linux-nfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.