Re: [PATCH 1/4] xfs_io: add a bulkstat command

From: Eric Sandeen <sandeen@sandeen.net>
To: "Darrick J. Wong" <darrick.wong@oracle.com>
Cc: linux-xfs@vger.kernel.org
Subject: Re: [PATCH 1/4] xfs_io: add a bulkstat command
Date: Mon, 7 Oct 2019 14:13:15 -0500	[thread overview]
Message-ID: <167bc3ea-2a68-fbb8-0040-e2d30aedad96@sandeen.net> (raw)
In-Reply-To: <20190930201510.GC66746@magnolia>

On 9/30/19 3:15 PM, Darrick J. Wong wrote:
> On Mon, Sep 30, 2019 at 03:02:27PM -0500, Eric Sandeen wrote:
>> On 9/26/19 11:18 PM, Darrick J. Wong wrote:
>>>>> +
>>>>> +	inumbers_cmd.args =
>>>>> +		_("[-a agno] [-d] [-e endino] [-n batchsize] [-s startino]");
>>>> <missing the -v option>
>>>>
>>>>> +	inumbers_cmd.oneline = _("Query inode groups in a filesystem");
>>>> I'm confused, why aren't all these ^^^ just in the structure definitions?
>>> All of these ... what?  I'm confused, sorry.
>>>
>>
>> I'm wondering why these 2 fields get set up in bulkstat_init(), vs at
>> cmdinfo_t structure definition time, i.e.
>>
>> static cmdinfo_t        inumbers_cmd = {
>>         .name = "inumbers",
>>         .cfunc = inumbers_f,
>>         .argmin = 0,
>>         .argmax = -1,
>>         .flags = CMD_NOMAP_OK | CMD_FLAG_ONESHOT,
>>         .args =
>> _("[-a agno] [-d] [-e endino] [-n batchsize] [-s startino] [-v version]");
>>         .oneline = _("Query inode groups in a filesystem");
>>         .help = inumbers_help,
>> };
>>
>> like ~every other command does?
> 
> [repeating irc conversation]
> 
> _() is a function, but static initializers require constant rvalues.

Sorry, my bad for missing that.

Thanks,
-Eric