Re: [PATCH] ASoC: loongson: fix address space confusion

From: Mark Brown <broonie@kernel.org>
To: Yingkun Meng <mengyingkun@loongson.cn>, Arnd Bergmann <arnd@kernel.org>
Cc: Arnd Bergmann <arnd@arndb.de>,
	Liam Girdwood <lgirdwood@gmail.com>,
	Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
	alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ASoC: loongson: fix address space confusion
Date: Thu, 22 Jun 2023 23:33:37 +0100	[thread overview]
Message-ID: <168747321729.318849.3547476102614344468.b4-ty@kernel.org> (raw)
In-Reply-To: <20230622101235.3230941-1-arnd@kernel.org>

On Thu, 22 Jun 2023 12:12:22 +0200, Arnd Bergmann wrote:
> The i2s driver uses the mapped __iomem address of the FIFO as the DMA
> address for the device. This apparently works on loongarch because of
> the way it handles __iomem pointers as aliases of physical addresses,
> but this is not portable to other architectures and causes a compiler
> warning when dma addresses are not the same size as pointers:
> 
> sound/soc/loongson/loongson_i2s_pci.c: In function 'loongson_i2s_pci_probe':
> sound/soc/loongson/loongson_i2s_pci.c:110:29: error: cast from pointer to integer of different size [-Werror=pointer-to-int-cast]
>   110 |         tx_data->dev_addr = (dma_addr_t)i2s->reg_base + LS_I2S_TX_DATA;
>       |                             ^
> sound/soc/loongson/loongson_i2s_pci.c:113:29: error: cast from pointer to integer of different size [-Werror=pointer-to-int-cast]
>   113 |         rx_data->dev_addr = (dma_addr_t)i2s->reg_base + LS_I2S_RX_DATA;
>       |                             ^
> 
> [...]

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next

Thanks!

[1/1] ASoC: loongson: fix address space confusion
      commit: 012fa2622e30675f61413485785e708ba02be78b

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark