From: patchwork-bot+netdevbpf@kernel.org
To: Song Liu <song@kernel.org>
Cc: bpf@vger.kernel.org, ast@kernel.org, daniel@iogearbox.net,
andrii@kernel.org, martin.lau@linux.dev, kernel-team@meta.com,
iii@linux.ibm.com
Subject: Re: [PATCH bpf 0/2] s390/bpf: Fix arch_prepare_bpf_trampoline
Date: Tue, 19 Sep 2023 10:10:22 +0000 [thread overview]
Message-ID: <169511822276.32013.17640068962746661120.git-patchwork-notify@kernel.org> (raw)
In-Reply-To: <20230919060258.3237176-1-song@kernel.org>
Hello:
This series was applied to bpf/bpf.git (master)
by Alexei Starovoitov <ast@kernel.org>:
On Mon, 18 Sep 2023 23:02:56 -0700 you wrote:
> While working on trampoline, I found s390's arch_prepare_bpf_trampoline
> returns 0 on success, which breaks struct_ops. However, the CI doesn't
> catch this issue. Turns out test_progs:bpf_tcp_ca doesn't really test
> members of a struct_ops are actually called via the trampolines.
>
> 1/2 fixes arch_prepare_bpf_trampoline for s390.
> 2/2 adds a check to test_progs:bpf_tcp_ca to verify bpf_cubic_acked() is
> indeed called by the trampoline. Without 1/2, this check would fail on
> s390.
>
> [...]
Here is the summary with links:
- [bpf,1/2] s390/bpf: Let arch_prepare_bpf_trampoline return program size
https://git.kernel.org/bpf/bpf/c/cf094baa3e0f
- [bpf,2/2] selftests/bpf: Check bpf_cubic_acked() is called via struct_ops
https://git.kernel.org/bpf/bpf/c/48f5e7d3f730
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
prev parent reply other threads:[~2023-09-19 10:10 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-19 6:02 [PATCH bpf 0/2] s390/bpf: Fix arch_prepare_bpf_trampoline Song Liu
2023-09-19 6:02 ` [PATCH bpf 1/2] s390/bpf: Let arch_prepare_bpf_trampoline return program size Song Liu
2023-09-19 9:04 ` Ilya Leoshkevich
2023-09-19 6:02 ` [PATCH bpf 2/2] selftests/bpf: Check bpf_cubic_acked() is called via struct_ops Song Liu
2023-09-19 9:05 ` Ilya Leoshkevich
2023-09-19 10:10 ` patchwork-bot+netdevbpf [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=169511822276.32013.17640068962746661120.git-patchwork-notify@kernel.org \
--to=patchwork-bot+netdevbpf@kernel.org \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=iii@linux.ibm.com \
--cc=kernel-team@meta.com \
--cc=martin.lau@linux.dev \
--cc=song@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.