From: patchwork-bot+netdevbpf@kernel.org
To: Daniel Borkmann <daniel@iogearbox.net>
Cc: bpf@vger.kernel.org, martin.lau@kernel.org, razor@blackwall.org,
syzbot+baa44e3dbbe48e05c1ad@syzkaller.appspotmail.com,
syzbot+b97d20ed568ce0951a06@syzkaller.appspotmail.com,
syzbot+2558ca3567a77b7af4e3@syzkaller.appspotmail.com
Subject: Re: [PATCH bpf 1/2] bpf, mprog: Fix maximum program check on mprog attachment
Date: Fri, 29 Sep 2023 23:00:26 +0000 [thread overview]
Message-ID: <169602842686.5238.5579305423276755854.git-patchwork-notify@kernel.org> (raw)
In-Reply-To: <20230929204121.20305-1-daniel@iogearbox.net>
Hello:
This series was applied to bpf/bpf.git (master)
by Andrii Nakryiko <andrii@kernel.org>:
On Fri, 29 Sep 2023 22:41:20 +0200 you wrote:
> After Paul's recent improvement to syzkaller to improve coverage for
> bpf_mprog and tcx, it hit a splat that the program limit was surpassed.
> What happened is that the maximum number of progs got added, followed
> by another prog add request which adds with BPF_F_BEFORE flag relative
> to the last program in the array. The idx >= bpf_mprog_max() check in
> bpf_mprog_attach() still passes because the index is below the maximum
> but the maximum will be surpassed. We need to add a check upfront for
> insertions to catch this situation.
>
> [...]
Here is the summary with links:
- [bpf,1/2] bpf, mprog: Fix maximum program check on mprog attachment
https://git.kernel.org/bpf/bpf/c/f9b0e1088bbf
- [bpf,2/2] selftest/bpf: Add various selftests for program limits
https://git.kernel.org/bpf/bpf/c/4cb893e89221
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
prev parent reply other threads:[~2023-09-29 23:00 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-29 20:41 [PATCH bpf 1/2] bpf, mprog: Fix maximum program check on mprog attachment Daniel Borkmann
2023-09-29 20:41 ` [PATCH bpf 2/2] selftest/bpf: Add various selftests for program limits Daniel Borkmann
2023-09-29 23:00 ` patchwork-bot+netdevbpf [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=169602842686.5238.5579305423276755854.git-patchwork-notify@kernel.org \
--to=patchwork-bot+netdevbpf@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=martin.lau@kernel.org \
--cc=razor@blackwall.org \
--cc=syzbot+2558ca3567a77b7af4e3@syzkaller.appspotmail.com \
--cc=syzbot+b97d20ed568ce0951a06@syzkaller.appspotmail.com \
--cc=syzbot+baa44e3dbbe48e05c1ad@syzkaller.appspotmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.