From: "Darrick J. Wong" <djwong@kernel.org>
To: djwong@kernel.org
Cc: Christoph Hellwig <hch@lst.de>,
linux-xfs@vger.kernel.org, osandov@fb.com, hch@lst.de
Subject: [PATCH 1/8] xfs: fix units conversion error in xfs_bmap_del_extent_delay
Date: Thu, 19 Oct 2023 09:22:34 -0700 [thread overview]
Message-ID: <169773210138.225045.16946186575490390808.stgit@frogsfrogsfrogs> (raw)
In-Reply-To: <169773210112.225045.8142885021045785858.stgit@frogsfrogsfrogs>
From: Darrick J. Wong <djwong@kernel.org>
The unit conversions in this function do not make sense. First we
convert a block count to bytes, then divide that bytes value by
rextsize, which is in blocks, to get an rt extent count. You can't
divide bytes by blocks to get a (possibly multiblock) extent value.
Fortunately nobody uses delalloc on the rt volume so this hasn't
mattered.
Fixes: fa5c836ca8eb5 ("xfs: refactor xfs_bunmapi_cow")
Signed-off-by: Darrick J. Wong <djwong@kernel.org>
Reviewed-by: Christoph Hellwig <hch@lst.de>
---
fs/xfs/libxfs/xfs_bmap.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/xfs/libxfs/xfs_bmap.c b/fs/xfs/libxfs/xfs_bmap.c
index 26bfa34b4bbf..617cc7e78e38 100644
--- a/fs/xfs/libxfs/xfs_bmap.c
+++ b/fs/xfs/libxfs/xfs_bmap.c
@@ -4827,7 +4827,7 @@ xfs_bmap_del_extent_delay(
ASSERT(got_endoff >= del_endoff);
if (isrt) {
- uint64_t rtexts = XFS_FSB_TO_B(mp, del->br_blockcount);
+ uint64_t rtexts = del->br_blockcount;
do_div(rtexts, mp->m_sb.sb_rextsize);
xfs_mod_frextents(mp, rtexts);
next prev parent reply other threads:[~2023-10-19 16:22 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-19 16:07 [ANNOUNCE] xfs-linux: realtime work branch rtalloc-speedups-6.7 updated to e0f7422f54b0 Darrick J. Wong
2023-10-19 16:19 ` [PATCHSET v1.1 0/4] xfs: minor bugfixes for rt stuff Darrick J. Wong
2023-10-19 16:21 ` [PATCH 1/4] xfs: bump max fsgeom struct version Darrick J. Wong
2023-10-19 16:21 ` [PATCH 2/4] xfs: hoist freeing of rt data fork extent mappings Darrick J. Wong
2023-10-19 16:22 ` [PATCH 3/4] xfs: prevent rt growfs when quota is enabled Darrick J. Wong
2023-10-19 16:22 ` [PATCH 4/4] xfs: rt stubs should return negative errnos when rt disabled Darrick J. Wong
2023-10-19 16:20 ` [PATCHSET v1.1 0/8] xfs: clean up realtime type usage Darrick J. Wong
2023-10-19 16:22 ` Darrick J. Wong [this message]
2023-10-19 16:22 ` [PATCH 2/8] xfs: make sure maxlen is still congruent with prod when rounding down Darrick J. Wong
2023-10-19 16:23 ` [PATCH 3/8] xfs: move the xfs_rtbitmap.c declarations to xfs_rtbitmap.h Darrick J. Wong
2023-10-19 16:23 ` [PATCH 4/8] xfs: convert xfs_extlen_t to xfs_rtxlen_t in the rt allocator Darrick J. Wong
2023-10-19 16:23 ` [PATCH 5/8] xfs: convert rt bitmap/summary block numbers to xfs_fileoff_t Darrick J. Wong
2023-10-19 16:23 ` [PATCH 6/8] xfs: convert rt bitmap extent lengths to xfs_rtbxlen_t Darrick J. Wong
2023-10-19 16:24 ` [PATCH 7/8] xfs: rename xfs_verify_rtext to xfs_verify_rtbext Darrick J. Wong
2023-10-19 16:24 ` [PATCH 8/8] xfs: convert rt extent numbers to xfs_rtxnum_t Darrick J. Wong
2023-10-19 16:20 ` [PATCHSET v1.1 0/7] xfs: refactor rt extent unit conversions Darrick J. Wong
2023-10-19 16:24 ` [PATCH 1/7] xfs: create a helper to convert rtextents to rtblocks Darrick J. Wong
2023-10-19 16:24 ` [PATCH 2/7] xfs: create a helper to compute leftovers of realtime extents Darrick J. Wong
2023-10-19 16:25 ` [PATCH 3/7] xfs: create a helper to convert extlen to rtextlen Darrick J. Wong
2023-10-19 16:25 ` [PATCH 4/7] xfs: create helpers to convert rt block numbers to rt extent numbers Darrick J. Wong
2023-10-19 16:25 ` [PATCH 5/7] xfs: convert do_div calls to xfs_rtb_to_rtx helper calls Darrick J. Wong
2023-10-19 16:25 ` [PATCH 6/7] xfs: create rt extent rounding helpers for realtime extent blocks Darrick J. Wong
2023-10-19 16:26 ` [PATCH 7/7] xfs: use shifting and masking when converting rt extents, if possible Darrick J. Wong
2023-10-19 16:20 ` [PATCHSET v1.1 0/5] xfs: refactor rtbitmap/summary macros Darrick J. Wong
2023-10-19 16:26 ` [PATCH 1/5] xfs: convert the rtbitmap block and bit macros to static inline functions Darrick J. Wong
2023-10-19 16:26 ` [PATCH 2/5] xfs: remove XFS_BLOCKWSIZE and XFS_BLOCKWMASK macros Darrick J. Wong
2023-10-19 16:27 ` [PATCH 3/5] xfs: convert open-coded xfs_rtword_t pointer accesses to helper Darrick J. Wong
2023-10-19 16:27 ` [PATCH 4/5] xfs: convert rt summary macros to helpers Darrick J. Wong
2023-10-19 16:27 ` [PATCH 5/5] xfs: create helpers for rtbitmap block/wordcount computations Darrick J. Wong
2023-10-19 16:21 ` [PATCHSET v1.2 0/4] xfs: refactor rtbitmap/summary accessors Darrick J. Wong
2023-10-19 16:27 ` [PATCH 1/4] xfs: create a helper to handle logging parts of rt bitmap/summary blocks Darrick J. Wong
2023-10-20 6:20 ` Christoph Hellwig
2023-10-20 15:20 ` Darrick J. Wong
2023-10-19 16:28 ` [PATCH 2/4] xfs: use accessor functions for bitmap words Darrick J. Wong
2023-10-19 16:28 ` [PATCH 3/4] xfs: create helpers for rtsummary block/wordcount computations Darrick J. Wong
2023-10-19 16:28 ` [PATCH 4/4] xfs: use accessor functions for summary info words Darrick J. Wong
2023-10-19 16:21 ` [PATCHSET v2.3 0/9] xfs: CPU usage optimizations for realtime allocator Darrick J. Wong
2023-10-19 16:28 ` [PATCH 1/9] xfs: consolidate realtime allocation arguments Darrick J. Wong
2023-10-19 16:29 ` [PATCH 2/9] xfs: cache last bitmap block in realtime allocator Darrick J. Wong
2023-10-19 16:29 ` [PATCH 3/9] xfs: simplify xfs_rtbuf_get calling conventions Darrick J. Wong
2023-10-19 16:29 ` [PATCH 4/9] xfs: simplify rt bitmap/summary block accessor functions Darrick J. Wong
2023-10-19 16:29 ` [PATCH 5/9] xfs: invert the realtime summary cache Darrick J. Wong
2023-10-19 16:30 ` [PATCH 6/9] xfs: return maximum free size from xfs_rtany_summary() Darrick J. Wong
2023-10-19 16:30 ` [PATCH 7/9] xfs: limit maxlen based on available space in xfs_rtallocate_extent_near() Darrick J. Wong
2023-10-19 16:30 ` [PATCH 8/9] xfs: don't try redundant allocations " Darrick J. Wong
2023-10-19 16:30 ` [PATCH 9/9] xfs: don't look for end of extent further than necessary " Darrick J. Wong
-- strict thread matches above, loose matches on Subject: below --
2023-10-17 15:46 [PATCHSET RFC v1.1 0/8] xfs: clean up realtime type usage Darrick J. Wong
2023-10-17 15:48 ` [PATCH 1/8] xfs: fix units conversion error in xfs_bmap_del_extent_delay Darrick J. Wong
2023-10-17 16:01 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=169773210138.225045.16946186575490390808.stgit@frogsfrogsfrogs \
--to=djwong@kernel.org \
--cc=hch@lst.de \
--cc=linux-xfs@vger.kernel.org \
--cc=osandov@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.