From: Aleksa Sarai <asarai@suse.com>
To: Michal Hocko <mhocko@kernel.org>, Oleg Nesterov <oleg@redhat.com>
Cc: LKML <linux-kernel@vger.kernel.org>,
strace-devel@lists.sourceforge.net,
Mike Galbraith <umgwanakikbuti@gmail.com>
Subject: Re: strace lockup when tracing exec in go
Date: Fri, 23 Sep 2016 11:17:03 +1000 [thread overview]
Message-ID: <16e6f7cc-0ba1-252a-f87f-486520cd5893@suse.com> (raw)
In-Reply-To: <20160922135301.GF11875@dhcp22.suse.cz>
>>>>> This patch doesn't help, nor does the previous patch... but with both
>>>>> applied, all is well. All you have to do now is figure out why :)
>>>>
>>>> Ohh, I should be more explicit, this needs the mm_access part as well.
>>>> Sorry for not being clear enough. So the full change is
>>>
>>> Ah. That was gonna happen after lunch, but since you already know it
>>> works, I can get back to un-b0rking one of my trees.
>>
>> Yeah, it should work. The testcase is running in a loop for more than
>> hour already and everything seems to be ok. Now the question is whether
>> the fix is really correct which is something for Oleg.
>>
>> Also I think there is at least one more issue lurking there. Without or
>> without the patch I can make tracer get stuck in do_wait waiting for
>> task which doesn't seem to be alive anymore. I will report it separately
>> after this one gets resolved to not pull more confusion in.
>
> OK, the test in the loop has survived 3h of runtime without a single
> lockup so the patch seems to be working for this case. I am posting the
> patch with the full changelog, let's see if it is correct as well. As
> I've said earlier this might be a strace bug which does an unexpected
> syscall while it should be doing wait on the child process instead.
>
> If the patch is correct then I would mark it for stable as well.
This patch fixes the test case, but it also fixes the original issue
(that strace of runC would fail when the container init process is
exec-ing the user init process). Thanks Michal, I'll apply it to my
local kernel. :D
--
Aleksa Sarai
Software Engineer (Containers)
SUSE Linux GmbH
https://www.cyphar.com/
next prev parent reply other threads:[~2016-09-23 1:16 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-21 15:29 strace lockup when tracing exec in go Michal Hocko
2016-09-22 4:15 ` Mike Galbraith
2016-09-22 8:01 ` Michal Hocko
2016-09-22 8:20 ` Aleksa Sarai
2016-09-22 8:36 ` Michal Hocko
2016-09-22 9:40 ` Mike Galbraith
2016-09-22 9:53 ` Michal Hocko
2016-09-22 10:09 ` Mike Galbraith
2016-09-22 11:09 ` Michal Hocko
2016-09-22 13:53 ` Michal Hocko
2016-09-23 1:17 ` Aleksa Sarai [this message]
2016-09-23 10:21 ` Oleg Nesterov
2016-09-23 11:18 ` Michal Hocko
2016-09-23 13:21 ` Oleg Nesterov
2016-09-23 13:40 ` Michal Hocko
2016-09-23 14:07 ` Oleg Nesterov
2016-09-23 14:19 ` Michal Hocko
2016-09-23 9:50 ` Oleg Nesterov
2016-09-23 11:23 ` Michal Hocko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=16e6f7cc-0ba1-252a-f87f-486520cd5893@suse.com \
--to=asarai@suse.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mhocko@kernel.org \
--cc=oleg@redhat.com \
--cc=strace-devel@lists.sourceforge.net \
--cc=umgwanakikbuti@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.