From: "Darrick J. Wong" <djwong@kernel.org>
To: djwong@kernel.org
Cc: linux-xfs@vger.kernel.org, hch@lst.de
Subject: [PATCHSET v29.4 10/13] xfs: move orphan files to lost and found
Date: Mon, 26 Feb 2024 18:18:39 -0800 [thread overview]
Message-ID: <170900014852.939668.10415471648919853088.stgit@frogsfrogsfrogs> (raw)
Hi all,
Orphaned files are defined to be files with nonzero ondisk link count
but no observable parent directory. This series enables online repair
to reparent orphaned files into the filesystem directory tree, and wires
up this reparenting ability into the directory, file link count, and
parent pointer repair functions. This is how we fix files with positive
link count that are not reachable through the directory tree.
This patch will also create the orphanage directory (lost+found) if it
is not present. In contrast to xfs_repair, we follow e2fsck in creating
the lost+found without group or other-owner access to avoid accidental
disclosure of files that were previously hidden by an 0700 directory.
That's silly security, but people have been known to do it.
If you're going to start using this code, I strongly recommend pulling
from my git trees, which are linked below.
This has been running on the djcloud for months with no problems. Enjoy!
Comments and questions are, as always, welcome.
--D
kernel git tree:
https://git.kernel.org/cgit/linux/kernel/git/djwong/xfs-linux.git/log/?h=repair-orphanage
---
Commits in this patchset:
* xfs: move orphan files to the orphanage
* xfs: move files to orphanage instead of letting nlinks drop to zero
* xfs: ensure dentry consistency when the orphanage adopts a file
---
.../filesystems/xfs/xfs-online-fsck-design.rst | 20 -
fs/xfs/Makefile | 1
fs/xfs/scrub/dir_repair.c | 130 ++++
fs/xfs/scrub/nlinks.c | 11
fs/xfs/scrub/nlinks.h | 6
fs/xfs/scrub/nlinks_repair.c | 124 ++++
fs/xfs/scrub/orphanage.c | 587 ++++++++++++++++++++
fs/xfs/scrub/orphanage.h | 75 +++
fs/xfs/scrub/parent_repair.c | 98 +++
fs/xfs/scrub/repair.h | 2
fs/xfs/scrub/scrub.c | 2
fs/xfs/scrub/scrub.h | 4
fs/xfs/scrub/trace.c | 1
fs/xfs/scrub/trace.h | 96 +++
fs/xfs/xfs_inode.c | 6
fs/xfs/xfs_inode.h | 1
16 files changed, 1130 insertions(+), 34 deletions(-)
create mode 100644 fs/xfs/scrub/orphanage.c
create mode 100644 fs/xfs/scrub/orphanage.h
next reply other threads:[~2024-02-27 2:18 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-27 2:18 Darrick J. Wong [this message]
2024-02-27 2:32 ` [PATCH 1/3] xfs: move orphan files to the orphanage Darrick J. Wong
2024-02-28 17:21 ` Christoph Hellwig
2024-02-27 2:32 ` [PATCH 2/3] xfs: move files to orphanage instead of letting nlinks drop to zero Darrick J. Wong
2024-02-28 17:23 ` Christoph Hellwig
2024-02-27 2:32 ` [PATCH 3/3] xfs: ensure dentry consistency when the orphanage adopts a file Darrick J. Wong
2024-02-28 17:24 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=170900014852.939668.10415471648919853088.stgit@frogsfrogsfrogs \
--to=djwong@kernel.org \
--cc=hch@lst.de \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.