From: Amit Kucheria <amit.kucheria@linaro.org>
To: linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org,
bjorn.andersson@linaro.org, edubezval@gmail.com,
agross@kernel.org, masneyb@onstation.org, swboyd@chromium.org,
julia.lawall@lip6.fr, Amit Kucheria <amit.kucheria@verdurent.com>,
Daniel Lezcano <daniel.lezcano@linaro.org>,
Mark Rutland <mark.rutland@arm.com>,
Rob Herring <robh+dt@kernel.org>, Zhang Rui <rui.zhang@intel.com>
Cc: linux-pm@vger.kernel.org
Subject: [PATCH v6 03/15] drivers: thermal: tsens: Add __func__ identifier to debug statements
Date: Mon, 21 Oct 2019 16:05:22 +0530 [thread overview]
Message-ID: <18717de35f31098d3ebc12564c2767b6d54d37d8.1571652874.git.amit.kucheria@linaro.org> (raw)
In-Reply-To: <cover.1571652874.git.amit.kucheria@linaro.org>
In-Reply-To: <cover.1571652874.git.amit.kucheria@linaro.org>
Printing the function name when enabling debugging makes logs easier to
read.
Signed-off-by: Amit Kucheria <amit.kucheria@linaro.org>
Reviewed-by: Stephen Boyd <swboyd@chromium.org>
Reviewed-by: Daniel Lezcano <daniel.lezcano@linaro.org>
---
drivers/thermal/qcom/tsens-common.c | 8 ++++----
drivers/thermal/qcom/tsens.c | 6 +++---
2 files changed, 7 insertions(+), 7 deletions(-)
diff --git a/drivers/thermal/qcom/tsens-common.c b/drivers/thermal/qcom/tsens-common.c
index c037bdf92c663..7437bfe196e50 100644
--- a/drivers/thermal/qcom/tsens-common.c
+++ b/drivers/thermal/qcom/tsens-common.c
@@ -42,8 +42,8 @@ void compute_intercept_slope(struct tsens_priv *priv, u32 *p1,
for (i = 0; i < priv->num_sensors; i++) {
dev_dbg(priv->dev,
- "sensor%d - data_point1:%#x data_point2:%#x\n",
- i, p1[i], p2[i]);
+ "%s: sensor%d - data_point1:%#x data_point2:%#x\n",
+ __func__, i, p1[i], p2[i]);
priv->sensor[i].slope = SLOPE_DEFAULT;
if (mode == TWO_PT_CALIB) {
@@ -60,7 +60,7 @@ void compute_intercept_slope(struct tsens_priv *priv, u32 *p1,
priv->sensor[i].offset = (p1[i] * SLOPE_FACTOR) -
(CAL_DEGC_PT1 *
priv->sensor[i].slope);
- dev_dbg(priv->dev, "offset:%d\n", priv->sensor[i].offset);
+ dev_dbg(priv->dev, "%s: offset:%d\n", __func__, priv->sensor[i].offset);
}
}
@@ -209,7 +209,7 @@ int __init init_common(struct tsens_priv *priv)
if (ret)
goto err_put_device;
if (!enabled) {
- dev_err(dev, "tsens device is not enabled\n");
+ dev_err(dev, "%s: device not enabled\n", __func__);
ret = -ENODEV;
goto err_put_device;
}
diff --git a/drivers/thermal/qcom/tsens.c b/drivers/thermal/qcom/tsens.c
index 542a7f8c3d962..06c6bbd69a1a7 100644
--- a/drivers/thermal/qcom/tsens.c
+++ b/drivers/thermal/qcom/tsens.c
@@ -127,7 +127,7 @@ static int tsens_probe(struct platform_device *pdev)
of_property_read_u32(np, "#qcom,sensors", &num_sensors);
if (num_sensors <= 0) {
- dev_err(dev, "invalid number of sensors\n");
+ dev_err(dev, "%s: invalid number of sensors\n", __func__);
return -EINVAL;
}
@@ -156,7 +156,7 @@ static int tsens_probe(struct platform_device *pdev)
ret = priv->ops->init(priv);
if (ret < 0) {
- dev_err(dev, "tsens init failed\n");
+ dev_err(dev, "%s: init failed\n", __func__);
return ret;
}
@@ -164,7 +164,7 @@ static int tsens_probe(struct platform_device *pdev)
ret = priv->ops->calibrate(priv);
if (ret < 0) {
if (ret != -EPROBE_DEFER)
- dev_err(dev, "tsens calibration failed\n");
+ dev_err(dev, "%s: calibration failed\n", __func__);
return ret;
}
}
--
2.17.1
next prev parent reply other threads:[~2019-10-21 10:35 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-21 10:35 [PATCH v6 00/15] thermal: qcom: tsens: Add interrupt support Amit Kucheria
2019-10-21 10:35 ` [PATCH v6 01/15] drivers: thermal: tsens: Get rid of id field in tsens_sensor Amit Kucheria
2019-10-21 10:35 ` [PATCH v6 02/15] drivers: thermal: tsens: Simplify code flow in tsens_probe Amit Kucheria
2019-10-21 10:35 ` Amit Kucheria [this message]
2019-10-21 10:35 ` [PATCH v6 04/15] drivers: thermal: tsens: Add debugfs support Amit Kucheria
2019-10-21 10:35 ` [PATCH v6 05/15] arm: dts: msm8974: thermal: Add thermal zones for each sensor Amit Kucheria
2019-10-27 5:12 ` Andy Gross
2019-10-21 10:35 ` [PATCH v6 06/15] arm64: dts: msm8916: thermal: Fixup HW ids for cpu sensors Amit Kucheria
2019-10-27 5:08 ` Andy Gross
2019-10-21 10:35 ` [PATCH v6 07/15] dt-bindings: thermal: tsens: Convert over to a yaml schema Amit Kucheria
2019-10-21 10:35 ` [PATCH v6 08/15] arm64: dts: sdm845: thermal: Add interrupt support Amit Kucheria
2019-10-27 5:10 ` Andy Gross
2019-10-21 10:35 ` [PATCH v6 09/15] arm64: dts: msm8996: " Amit Kucheria
2019-10-27 5:10 ` Andy Gross
2019-10-21 10:35 ` [PATCH v6 10/15] arm64: dts: msm8998: " Amit Kucheria
2019-10-27 5:10 ` Andy Gross
2019-10-21 10:35 ` [PATCH v6 11/15] arm64: dts: qcs404: " Amit Kucheria
2019-10-27 5:09 ` Andy Gross
2019-10-21 10:35 ` [PATCH v6 12/15] arm: dts: msm8974: " Amit Kucheria
2019-10-27 5:12 ` Andy Gross
2019-10-21 10:35 ` [PATCH v6 13/15] arm64: dts: msm8916: " Amit Kucheria
2019-10-27 5:08 ` Andy Gross
2019-10-21 10:35 ` [PATCH v6 14/15] drivers: thermal: tsens: Create function to return sign-extended temperature Amit Kucheria
2019-10-21 10:35 ` [PATCH v6 15/15] drivers: thermal: tsens: Add interrupt support Amit Kucheria
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=18717de35f31098d3ebc12564c2767b6d54d37d8.1571652874.git.amit.kucheria@linaro.org \
--to=amit.kucheria@linaro.org \
--cc=agross@kernel.org \
--cc=amit.kucheria@verdurent.com \
--cc=bjorn.andersson@linaro.org \
--cc=daniel.lezcano@linaro.org \
--cc=edubezval@gmail.com \
--cc=julia.lawall@lip6.fr \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=masneyb@onstation.org \
--cc=robh+dt@kernel.org \
--cc=rui.zhang@intel.com \
--cc=swboyd@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.