Re: [Qemu-devel] Re: [PATCH 01/10] vnc: refactor set_encodings

From: Alexander Graf <agraf@suse.de>
To: Corentin Chary <corentin.chary@gmail.com>
Cc: Anthony Liguori <aliguori@linux.vnet.ibm.com>,
	qemu-devel@nongnu.org, Adam Litke <agl@us.ibm.com>
Subject: Re: [Qemu-devel] Re: [PATCH 01/10] vnc: refactor set_encodings
Date: Tue, 18 May 2010 11:58:34 +0200	[thread overview]
Message-ID: <18951C40-C687-4F12-922F-D37C2A932D0B@suse.de> (raw)
In-Reply-To: <AANLkTiksGH6KIV1A8HJoWv4caM5auBkWQLa5hyVUYqCZ@mail.gmail.com>

On 18.05.2010, at 11:56, Corentin Chary wrote:

> On Tue, May 18, 2010 at 11:18 AM, Alexander Graf <agraf@suse.de> wrote:
>> 
>> On 18.05.2010, at 09:31, Corentin Chary wrote:
>> 
>> This is missing a patch description. When people later on either cherry-pick your commits or simply git show them, it's almost impossible to know what's going on.
>> So please always put in a patch description.
>> 
>> 
>> Alex
>> 
> 
> In this case, the description is all in the subject and the patch is
> pretty obvious.
> Should I really add something like "Create a new set_encoding()
> function to remove duplicate code in set_encodings()." ?

Yes. If possible, including the reasoning behind it. Something like:

Currently the code to specify which encoding we use is written out individually every time. Since we want to be able to add code to every singe occurence, let's move it to a helper function.

Alex