Re: [PATCH v4 0/3] PCI: Add a quirk to enable SVA for HiSilicon chip

From: Zhangfei Gao <zhangfei.gao@linaro.org>
To: Bjorn Helgaas <bhelgaas@google.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Arnd Bergmann <arnd@arndb.de>,
	jean-philippe <jean-philippe@linaro.org>,
	kenneth-lee-2012@foxmail.com, Wangzhou <wangzhou1@hisilicon.com>,
	helgaas <helgaas@kernel.org>
Cc: linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 0/3] PCI: Add a quirk to enable SVA for HiSilicon chip
Date: Wed, 16 Jun 2021 16:42:23 +0800	[thread overview]
Message-ID: <18e171fe-549b-6fa3-c9a0-c0d869b53445@linaro.org> (raw)
In-Reply-To: <1623209801-1709-1-git-send-email-zhangfei.gao@linaro.org>

Hi, Bjorn

On 2021/6/9 上午11:36, Zhangfei Gao wrote:
> HiSilicon KunPeng920 and KunPeng930 have devices appear as PCI but are
> actually on the AMBA bus. These fake PCI devices have PASID capability
> though not supporting TLP.
>
> Add a quirk to set pasid_no_tlp and dma-can-stall for these devices.
>
> Jean's dma-can-stall patchset has been accepted
> https://lore.kernel.org/linux-iommu/162314710744.3707892.6632600736379822229.b4-ty@kernel.org/

Would you mind take a look.
There is no dependence now, since he dependent patch set has been taken.

Thanks

>
> v4:
> Applied to Linux 5.13-rc2, and build successfully with only these three patches.
>
> v3:
> https://lore.kernel.org/linux-pci/1615258837-12189-1-git-send-email-zhangfei.gao@linaro.org/
> Rebase to Linux 5.12-rc1
> Change commit msg adding:
> Property dma-can-stall depends on patchset
> https://lore.kernel.org/linux-iommu/20210302092644.2553014-1-jean-philippe@linaro.org/
>
> By the way the patchset can directly applied on 5.12-rc1 and build successfully though
> without the dependent patchset.
>
> v2:
> Add a new pci_dev bit: pasid_no_tlp, suggested by Bjorn
> "Apparently these devices have a PASID capability.  I think you should
> add a new pci_dev bit that is specific to this idea of "PASID works
> without TLP prefixes" and then change pci_enable_pasid() to look at
> that bit as well as eetlp_prefix_path."
> https://lore.kernel.org/linux-pci/20210112170230.GA1838341@bjorn-Precision-5520/
>
> Zhangfei Gao (3):
>    PCI: PASID can be enabled without TLP prefix
>    PCI: Add a quirk to set pasid_no_tlp for HiSilicon chips
>    PCI: Set dma-can-stall for HiSilicon chips
>
>   drivers/pci/ats.c    |  2 +-
>   drivers/pci/quirks.c | 27 +++++++++++++++++++++++++++
>   include/linux/pci.h  |  1 +
>   3 files changed, 29 insertions(+), 1 deletion(-)
>