From: Jan Beulich <jbeulich@suse.com>
To: Roger Pau Monne <roger.pau@citrix.com>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>, Wei Liu <wl@xen.org>,
Anthony PERARD <anthony.perard@citrix.com>,
xen-devel@lists.xenproject.org
Subject: Re: [PATCH v7 03/11] libx86: introduce helper to fetch msr entry
Date: Tue, 25 Jan 2022 16:04:36 +0100 [thread overview]
Message-ID: <1903aa17-9820-cadf-1aaa-27e1ed616b69@suse.com> (raw)
In-Reply-To: <20220125144935.44394-4-roger.pau@citrix.com>
On 25.01.2022 15:49, Roger Pau Monne wrote:
> Use such helper in order to replace the code in
> x86_msr_copy_from_buffer. Note the introduced helper should not be
> directly called and instead x86_msr_get_entry should be used that will
> properly deal with const and non-const inputs.
>
> Note this requires making the raw fields uint64_t so that it can
> accommodate the maximum size of MSRs values, and in turn removing the
> truncation tests.
>
> Suggested-by: Andrew Cooper <andrew.cooper3@citrix.com>
> Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>
Reviewed-by: Jan Beulich <jbeulich@suse.com>
next prev parent reply other threads:[~2022-01-25 15:04 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-25 14:49 [PATCH v7 00/11] libs/guest: new CPUID/MSR interface Roger Pau Monne
2022-01-25 14:49 ` [PATCH v7 01/11] libx86: introduce helper to fetch cpuid leaf Roger Pau Monne
2022-01-25 15:03 ` Jan Beulich
2022-01-25 14:49 ` [PATCH v7 02/11] libs/guest: allow fetching a specific CPUID leaf from a cpu policy Roger Pau Monne
2022-01-25 14:49 ` [PATCH v7 03/11] libx86: introduce helper to fetch msr entry Roger Pau Monne
2022-01-25 15:04 ` Jan Beulich [this message]
2022-01-25 14:49 ` [PATCH v7 04/11] libs/guest: allow fetching a specific MSR entry from a cpu policy Roger Pau Monne
2022-01-25 14:49 ` [PATCH v7 05/11] libs/guest: make a cpu policy compatible with older Xen versions Roger Pau Monne
2022-01-25 14:49 ` [PATCH v7 06/11] libs/guest: introduce helper set cpu topology in cpu policy Roger Pau Monne
2022-01-25 14:49 ` [PATCH v7 07/11] libs/guest: rework xc_cpuid_xend_policy Roger Pau Monne
2022-01-25 14:49 ` [PATCH v7 08/11] libs/guest: apply a featureset into a cpu policy Roger Pau Monne
2022-01-25 14:49 ` [PATCH v7 09/11] libs/{light,guest}: implement xc_cpuid_apply_policy in libxl Roger Pau Monne
2022-01-25 14:49 ` [PATCH v7 10/11] libs/guest: (re)move xc_cpu_policy_apply_cpuid Roger Pau Monne
2022-01-25 14:49 ` [PATCH v7 11/11] x86/CPUID: shrink max_{,sub}leaf fields according to actual leaf contents Roger Pau Monne
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1903aa17-9820-cadf-1aaa-27e1ed616b69@suse.com \
--to=jbeulich@suse.com \
--cc=andrew.cooper3@citrix.com \
--cc=anthony.perard@citrix.com \
--cc=roger.pau@citrix.com \
--cc=wl@xen.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.