From: Denis Semakin <d.semakin@omprussia.ru>
To: snitzer <snitzer@redhat.com>
Cc: dm-devel <dm-devel@redhat.com>
Subject: Re: dm table: add support for secure erase forwarding [was: Re: Adaptation secure erase forwarding for 4.1x kernels]
Date: Mon, 26 Mar 2018 17:12:55 +0300 (MSK) [thread overview]
Message-ID: <1943462632.77431.1522073575389.JavaMail.zimbra@omprussia.ru> (raw)
In-Reply-To: <20180323153844.GA4914@redhat.com>
Also, will it be usefully to add a "get...()" function for
num_secure_erase_bios? Let's say get_num_secure_erase_bios(struct dm_target &ti);
As it's done for num_discard_bios...
----- Исходное сообщение -----
От: "snitzer" <snitzer@redhat.com>
Кому: "Denis Semakin"
Копия: "dm-devel" <dm-devel@redhat.com>
Отправленные: Пятница, 23 Март 2018 г 18:38:44
Тема: Re: dm table: add support for secure erase forwarding [was: Re: Adaptation secure erase forwarding for 4.1x kernels]
On Fri, Mar 23 2018 at 10:47am -0400,
Denis Semakin wrote:
> >I'd feel safer about having targets opt-in with setting (a new)
> >ti->num_secure_erase_bios.
> May be add a new field "bool secure_erase_supported:1" in dm_target structure instead?
> And set up it "true" in constructor for linear targets.
No, that type of change is for a DM target to support a feature even if
the underlying device doesn't.
As my previous email elaborated, ti->num_secure_erase_bios is the right
way forward.
Mike
--
Best regards,
Denis Semakin
Software Developer
Open Mobile Platform
--
dm-devel mailing list
dm-devel@redhat.com
https://www.redhat.com/mailman/listinfo/dm-devel
next prev parent reply other threads:[~2018-03-26 14:12 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-13 9:23 [PATCH] Adaptation secure erase forwarding for 4.1x kernels Denis Semakin
2018-03-22 15:10 ` [PATCH] dm table: add support for secure erase forwarding [was: Re: Adaptation secure erase forwarding for 4.1x kernels] Mike Snitzer
2018-03-23 8:14 ` Denis Semakin
2018-03-23 15:36 ` Mike Snitzer
2018-03-23 13:37 ` [PATCH] " Denis Semakin
2018-03-23 14:47 ` Denis Semakin
2018-03-23 15:38 ` Mike Snitzer
2018-03-26 7:45 ` Denis Semakin
2018-03-26 9:58 ` Denis Semakin
2018-03-26 14:12 ` Denis Semakin [this message]
2018-03-26 16:11 ` Mike Snitzer
2018-03-27 8:54 ` Denis Semakin
2018-03-27 9:03 ` Denis Semakin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1943462632.77431.1522073575389.JavaMail.zimbra@omprussia.ru \
--to=d.semakin@omprussia.ru \
--cc=dm-devel@redhat.com \
--cc=snitzer@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.