From: Arnd Bergmann <arnd@arndb.de>
To: Marc Zyngier <marc.zyngier@arm.com>
Cc: Shawn Lin <shawn.lin@rock-chips.com>,
Bjorn Helgaas <bhelgaas@google.com>,
linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-rockchip@lists.infradead.org,
Heiko Stuebner <heiko@sntech.de>,
Doug Anderson <dianders@chromium.org>,
Wenrui Li <wenrui.li@rock-chips.com>,
Rob Herring <robh+dt@kernel.org>,
devicetree@vger.kernel.org
Subject: Re: [PATCH v2 2/2] PCI: Rockchip: Add Rockchip PCIe controller support
Date: Wed, 08 Jun 2016 22:06:21 +0200 [thread overview]
Message-ID: <19495840.MdNPOj1Q7K@wuerfel> (raw)
In-Reply-To: <5757E397.40401@arm.com>
On Wednesday, June 8, 2016 10:21:27 AM CEST Marc Zyngier wrote:
> > + rockchip_pcie_enable_interrupts(port);
> > + if (!IS_ENABLED(CONFIG_PCI_MSI)) {
> > + err = rockchip_pcie_init_irq_domain(port);
> > + if (err < 0)
> > + goto err_vpcie;
>
> Why are you excluding wired interrupts if you have PCI_MSI configured?
> MSI allocation can fail, and wired interrupts become handy....
Also, a lot of drivers don't do MSI and rely on legacy interrupts.
Arnd
next prev parent reply other threads:[~2016-06-09 12:42 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-08 8:05 [PATCH v2 2/2] PCI: Rockchip: Add Rockchip PCIe controller support Shawn Lin
2016-06-08 8:05 ` Shawn Lin
2016-06-08 9:21 ` Marc Zyngier
2016-06-08 9:21 ` Marc Zyngier
2016-06-08 20:06 ` Arnd Bergmann [this message]
2016-06-10 1:35 ` kbuild test robot
2016-06-10 1:35 ` kbuild test robot
2016-06-10 4:00 ` Doug Anderson
2016-06-10 7:37 ` Marc Zyngier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=19495840.MdNPOj1Q7K@wuerfel \
--to=arnd@arndb.de \
--cc=bhelgaas@google.com \
--cc=devicetree@vger.kernel.org \
--cc=dianders@chromium.org \
--cc=heiko@sntech.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=marc.zyngier@arm.com \
--cc=robh+dt@kernel.org \
--cc=shawn.lin@rock-chips.com \
--cc=wenrui.li@rock-chips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.