From: Daniel Borkmann <daniel@iogearbox.net>
To: Lorenz Bauer <lorenz.bauer@isovalent.com>,
Martin KaFai Lau <martin.lau@linux.dev>,
Alexei Starovoitov <ast@kernel.org>,
Andrii Nakryiko <andrii@kernel.org>, Song Liu <song@kernel.org>,
Yonghong Song <yhs@fb.com>,
John Fastabend <john.fastabend@gmail.com>,
KP Singh <kpsingh@kernel.org>,
Stanislav Fomichev <sdf@google.com>, Hao Luo <haoluo@google.com>,
Jiri Olsa <jolsa@kernel.org>
Cc: Lorenz Bauer <lmb@isovalent.com>, Martin KaFai Lau <kafai@fb.com>,
bpf@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH bpf v2 1/2] btf: fix resolving BTF_KIND_VAR after ARRAY, STRUCT, UNION, PTR
Date: Mon, 6 Mar 2023 23:19:59 +0100 [thread overview]
Message-ID: <19d825ad-0ec3-9979-a157-99289339d438@iogearbox.net> (raw)
In-Reply-To: <20230306112138.155352-2-lmb@isovalent.com>
On 3/6/23 12:21 PM, Lorenz Bauer wrote:
> btf_datasec_resolve contains a bug that causes the following BTF
> to fail loading:
>
> [1] DATASEC a size=2 vlen=2
> type_id=4 offset=0 size=1
> type_id=7 offset=1 size=1
> [2] INT (anon) size=1 bits_offset=0 nr_bits=8 encoding=(none)
> [3] PTR (anon) type_id=2
> [4] VAR a type_id=3 linkage=0
> [5] INT (anon) size=1 bits_offset=0 nr_bits=8 encoding=(none)
> [6] TYPEDEF td type_id=5
> [7] VAR b type_id=6 linkage=0
>
[...]
> The fix is to reset resolve_mode to RESOLVE_TBD before attempting to
> resolve a VAR from a DATASEC.
>
> Fixes: 1dc92851849c ("bpf: kernel side support for BTF Var and DataSec")
> Signed-off-by: Lorenz Bauer <lmb@isovalent.com>
Looks like patchbot is on strike, the series got applied to bpf, thanks!
next prev parent reply other threads:[~2023-03-06 22:20 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-06 11:21 [PATCH bpf v2 0/2] fix resolving VAR after DATASEC Lorenz Bauer
2023-03-06 11:21 ` [PATCH bpf v2 1/2] btf: fix resolving BTF_KIND_VAR after ARRAY, STRUCT, UNION, PTR Lorenz Bauer
2023-03-06 22:19 ` Daniel Borkmann [this message]
2023-03-06 11:21 ` [PATCH bpf v2 2/2] selftests/bpf: check that modifier resolves after pointer Lorenz Bauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=19d825ad-0ec3-9979-a157-99289339d438@iogearbox.net \
--to=daniel@iogearbox.net \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=haoluo@google.com \
--cc=john.fastabend@gmail.com \
--cc=jolsa@kernel.org \
--cc=kafai@fb.com \
--cc=kpsingh@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lmb@isovalent.com \
--cc=lorenz.bauer@isovalent.com \
--cc=martin.lau@linux.dev \
--cc=sdf@google.com \
--cc=song@kernel.org \
--cc=yhs@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.