From: Christian Lindig <christian.lindig@citrix.com>
To: Andrew Cooper <Andrew.Cooper3@citrix.com>
Cc: Xen-devel <xen-devel@lists.xenproject.org>,
David Scott <dave@recoil.org>,
Edwin Torok <edvin.torok@citrix.com>,
Rob Hoes <Rob.Hoes@citrix.com>
Subject: Re: [PATCH v2 4/6] tools/oxenstored: Implement Domain.rebind_evtchn
Date: Thu, 1 Dec 2022 13:10:38 +0000 [thread overview]
Message-ID: <1ACBBE83-1A55-477A-BAF9-63B4C8A0D4D4@citrix.com> (raw)
In-Reply-To: <6c667e15-8a6c-753b-923d-fb5ea7839cc3@citrix.com>
> On 1 Dec 2022, at 12:10, Andrew Cooper <Andrew.Cooper3@citrix.com> wrote:
>
> I can keep the being/end if you'd prefer.
>
> Looking at the end result, it would actually shrink the patch, so is
> probably worth doing anyway for clarity. The net result is:
I think keeping the begin/end is a good idea - as it keeps the patch small. I was mostly arguing for automated formatting because in OCaml the unfortunate difference in what constitutes the resulting expression in if vs. match has lead to subtle bugs in the past.
— C
next prev parent reply other threads:[~2022-12-01 13:11 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-30 16:54 [PATCH v2 0/6] More Oxenstored live update fixes Andrew Cooper
2022-11-30 16:54 ` [PATCH v2 1/6] tools/oxenstored: Style fixes to Domain Andrew Cooper
2022-11-30 17:14 ` Edwin Torok
2022-12-01 11:11 ` Christian Lindig
2022-11-30 16:54 ` [PATCH v2 2/6] tools/oxenstored: Bind the DOM_EXC VIRQ in in Event.init() Andrew Cooper
2022-11-30 17:16 ` Edwin Torok
2022-12-01 11:27 ` Christian Lindig
2022-11-30 16:54 ` [PATCH v2 3/6] tools/oxenstored: Rename some 'port' variables to 'remote_port' Andrew Cooper
2022-11-30 17:16 ` Edwin Torok
2022-12-01 11:26 ` Christian Lindig
2022-12-01 12:02 ` Andrew Cooper
2022-11-30 16:54 ` [PATCH v2 4/6] tools/oxenstored: Implement Domain.rebind_evtchn Andrew Cooper
2022-11-30 17:15 ` Edwin Torok
2022-12-01 11:20 ` Christian Lindig
2022-12-01 12:10 ` Andrew Cooper
2022-12-01 13:10 ` Christian Lindig [this message]
2022-12-02 9:11 ` Edwin Torok
2022-11-30 16:54 ` [PATCH v2 5/6] tools/oxenstored: Rework Domain evtchn handling to use port_pair Andrew Cooper
2022-11-30 17:17 ` Edwin Torok
2022-12-01 11:59 ` Christian Lindig
2022-12-01 14:22 ` Andrew Cooper
2022-12-01 15:22 ` Edwin Torok
2022-11-30 16:54 ` [PATCH v2 6/6] tools/oxenstored: Keep /dev/xen/evtchn open across live update Andrew Cooper
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1ACBBE83-1A55-477A-BAF9-63B4C8A0D4D4@citrix.com \
--to=christian.lindig@citrix.com \
--cc=Andrew.Cooper3@citrix.com \
--cc=Rob.Hoes@citrix.com \
--cc=dave@recoil.org \
--cc=edvin.torok@citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.