From: Doug Goldstein <cardoe@cardoe.com>
To: Wei Liu <wei.liu2@citrix.com>,
Xen-devel <xen-devel@lists.xenproject.org>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
Ian Jackson <Ian.Jackson@eu.citrix.com>
Subject: Re: [PATCH for-4.7 0/6] Workaround gcc -Wmaybe-uninitialised false positive reports
Date: Fri, 6 May 2016 08:37:31 -0500 [thread overview]
Message-ID: <1a05c248-acd4-d07b-4cf1-2170b889b800@cardoe.com> (raw)
In-Reply-To: <1461942677-14564-1-git-send-email-wei.liu2@citrix.com>
[-- Attachment #1.1.1: Type: text/plain, Size: 1234 bytes --]
On 4/29/16 10:11 AM, Wei Liu wrote:
> On my Debian Jessie build box gcc complains about various maybe uninitialised
> variables when -g is in use. In fact gcc -Wmaybe-uninitialized is not very
> reliable according to gcc manpage, various search results and answer from
> someone on freenode #gcc channel.
>
> I go through those failures and try to provide some workaround for them.
> Please have a look if these fixes make sense or my analysis is correct.
>
> Wei.
>
> Wei Liu (6):
> rombios/tcgbios: initialise size in tcpa_extend_acpi_log
> rombios/tcgbios: initialise entry in HashLogEvent32
> rombios/tcgbios: initialise logdataptr in HashLogEvent32
> blktap2: initialise buf in vhd_util_check_footer
> blktap2: initialise buf to NULL in img2qcow.c:main
> blktap2: initialise buf in qcow2raw.c:main
>
> tools/blktap2/drivers/img2qcow.c | 2 +-
> tools/blktap2/drivers/qcow2raw.c | 2 +-
> tools/blktap2/vhd/lib/vhd-util-check.c | 2 +-
> tools/firmware/rombios/32bit/tcgbios/tcgbios.c | 6 +++---
> 4 files changed, 6 insertions(+), 6 deletions(-)
>
For the whole series:
Reviewed-by: Doug Goldstein <cardoe@cardoe.com>
--
Doug Goldstein
[-- Attachment #1.2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 959 bytes --]
[-- Attachment #2: Type: text/plain, Size: 126 bytes --]
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
next prev parent reply other threads:[~2016-05-06 13:37 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-29 15:11 [PATCH for-4.7 0/6] Workaround gcc -Wmaybe-uninitialised false positive reports Wei Liu
2016-04-29 15:11 ` [PATCH for-4.7 1/6] rombios/tcgbios: initialise size in tcpa_extend_acpi_log Wei Liu
2016-04-29 15:11 ` [PATCH for-4.7 2/6] rombios/tcgbios: initialise entry in HashLogEvent32 Wei Liu
2016-04-29 15:11 ` [PATCH for-4.7 3/6] rombios/tcgbios: initialise logdataptr " Wei Liu
2016-04-29 15:11 ` [PATCH for-4.7 4/6] blktap2: initialise buf in vhd_util_check_footer Wei Liu
2016-04-29 15:11 ` [PATCH for-4.7 5/6] blktap2: initialise buf to NULL in img2qcow.c:main Wei Liu
2016-04-29 15:11 ` [PATCH for-4.7 6/6] blktap2: initialise buf in qcow2raw.c:main Wei Liu
2016-05-06 11:15 ` [PATCH for-4.7 0/6] Workaround gcc -Wmaybe-uninitialised false positive reports Wei Liu
2016-05-06 13:37 ` Doug Goldstein [this message]
2016-05-06 14:48 ` Wei Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1a05c248-acd4-d07b-4cf1-2170b889b800@cardoe.com \
--to=cardoe@cardoe.com \
--cc=Ian.Jackson@eu.citrix.com \
--cc=andrew.cooper3@citrix.com \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.