From: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
To: Sam Protsenko <semen.protsenko@linaro.org>,
Alessandro Zummo <a.zummo@towertech.it>,
Alexandre Belloni <alexandre.belloni@bootlin.com>
Cc: linux-rtc@vger.kernel.org, linux-samsung-soc@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/4] rtc: s3c: Extract read/write IO into separate functions
Date: Tue, 19 Oct 2021 18:24:43 +0200 [thread overview]
Message-ID: <1a71e63d-0586-2208-bd84-6bc2d15147e4@canonical.com> (raw)
In-Reply-To: <20211019131724.3109-4-semen.protsenko@linaro.org>
On 19/10/2021 15:17, Sam Protsenko wrote:
> Create dedicated functions for I/O operations and BCD conversion. It can
> be useful to separete those from representation conversion and other
> stuff found in RTC callbacks, e.g. for initializing RTC registers.
> This patch does not introduce any functional changes, it's merely
> refactoring change.
>
> Signed-off-by: Sam Protsenko <semen.protsenko@linaro.org>
> ---
> drivers/rtc/rtc-s3c.c | 98 +++++++++++++++++++++++++++----------------
> 1 file changed, 61 insertions(+), 37 deletions(-)
>
Looks correct:
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
Best regards,
Krzysztof
next prev parent reply other threads:[~2021-10-19 16:24 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-19 13:17 [PATCH 0/4] rtc: s3c: S3C driver improvements Sam Protsenko
2021-10-19 13:17 ` [PATCH 1/4] rtc: s3c: Remove usage of devm_rtc_device_register() Sam Protsenko
2021-10-19 16:11 ` Krzysztof Kozlowski
2021-10-19 13:17 ` [PATCH 2/4] rtc: s3c: Add time range Sam Protsenko
2021-10-19 16:17 ` Krzysztof Kozlowski
2021-10-19 16:22 ` Krzysztof Kozlowski
2021-10-19 16:35 ` Sam Protsenko
2021-10-19 17:48 ` Alexandre Belloni
2021-10-19 19:12 ` Sam Protsenko
2021-10-19 21:04 ` Alexandre Belloni
2021-10-20 6:29 ` Krzysztof Kozlowski
2021-10-21 19:48 ` Sam Protsenko
2021-10-21 20:55 ` Alexandre Belloni
2021-10-19 16:20 ` Alexandre Belloni
2021-10-19 16:31 ` Sam Protsenko
2021-10-19 17:46 ` Alexandre Belloni
2021-10-19 13:17 ` [PATCH 3/4] rtc: s3c: Extract read/write IO into separate functions Sam Protsenko
2021-10-19 16:24 ` Krzysztof Kozlowski [this message]
2021-10-19 13:17 ` [PATCH 4/4] rtc: s3c: Fix RTC read on first boot Sam Protsenko
2021-10-19 15:48 ` Alexandre Belloni
2021-10-19 16:04 ` Sam Protsenko
2021-10-19 16:19 ` Krzysztof Kozlowski
2021-10-19 16:10 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1a71e63d-0586-2208-bd84-6bc2d15147e4@canonical.com \
--to=krzysztof.kozlowski@canonical.com \
--cc=a.zummo@towertech.it \
--cc=alexandre.belloni@bootlin.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rtc@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=semen.protsenko@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.