From: Paolo Bonzini <pbonzini@redhat.com>
To: Sean Christopherson <seanjc@google.com>
Cc: kvm@vger.kernel.org
Subject: Re: [kvm-unit-tests PATCH 00/12] nSVM: NPT improvements and cleanups
Date: Wed, 23 Jun 2021 13:52:52 +0200 [thread overview]
Message-ID: <1b1dc5cf-f602-1ec9-2440-229c599dd7da@redhat.com> (raw)
In-Reply-To: <20210622210047.3691840-1-seanjc@google.com>
On 22/06/21 23:00, Sean Christopherson wrote:
> The first chunk of this series (everything up to the lib/vmalloc patch)
> are cleanups and bug fixes for existing nSVM tests that I collected on
> my first attempt at the new NPT test. I originally wanted to piggyback
> the existing "v1" nSVM tests and implemented the fixes/cleanups, but that
> approach didn't go so well because of the v1 infrastructure limitations.
>
> The common lib/vmalloc changes are to allow arch code to pass arbitrary
> data to its setup_mmu() function. x86-64 uses the param to avoid marking
> PTEs a USER so that tests can enable SMEP (#PF if supervisor mode fetches
> from a USER PTE) without exploding or having to duplicate all page tables.
>
> The "new" test targets nested NPT by running L1 and L2 with different
> EFER.NX and CR4.SMEP settings to verify that KVM uses the correct MMU
> settings when injecting page faults.
>
> Sean Christopherson (12):
> nSVM: Provide expected and actual exit codes on VMRUN test failure
> nSVM: Replace open coded NX manipulation with appropriate macros
> nSVM: Reset the VMCB before every v1 test
> nSVM: Explicitly save/update/restore EFER.NX for NPT NX test
> nSVM: Remove NPT reserved bits tests (new one on the way)
> nSVM: Stop forcing EFER.NX=1 for all tests
> nSVM: Remove a superfluous modification of guest EFER.NX in NPT NX
> test
> nSVM: Clear guest's EFER.NX in NPT NX test
> lib/vmalloc: Let arch code pass a value to its setup_mmu() helper
> x86: Let tests omit PT_USER_MASK when configuring virtual memory
> x86: Add GBPAGES CPUID macro, clean up CPUID comments
> nSVM: Add test for NPT reserved bit and #NPF error code behavior
>
> lib/arm/mmu.c | 2 +-
> lib/s390x/mmu.c | 3 +-
> lib/vmalloc.c | 9 +-
> lib/vmalloc.h | 4 +-
> lib/x86/processor.h | 15 +--
> lib/x86/vm.c | 15 ++-
> s390x/uv-host.c | 2 +-
> x86/svm.c | 10 +-
> x86/svm_tests.c | 220 +++++++++++++++++++++++++++++++-------------
> 9 files changed, 196 insertions(+), 84 deletions(-)
>
Queued, thanks.
Paolo
prev parent reply other threads:[~2021-06-23 11:52 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-22 21:00 [kvm-unit-tests PATCH 00/12] nSVM: NPT improvements and cleanups Sean Christopherson
2021-06-22 21:00 ` [kvm-unit-tests PATCH 01/12] nSVM: Provide expected and actual exit codes on VMRUN test failure Sean Christopherson
2021-06-22 21:00 ` [kvm-unit-tests PATCH 02/12] nSVM: Replace open coded NX manipulation with appropriate macros Sean Christopherson
2021-06-22 21:00 ` [kvm-unit-tests PATCH 03/12] nSVM: Reset the VMCB before every v1 test Sean Christopherson
2021-06-22 21:00 ` [kvm-unit-tests PATCH 04/12] nSVM: Explicitly save/update/restore EFER.NX for NPT NX test Sean Christopherson
2021-06-22 21:00 ` [kvm-unit-tests PATCH 05/12] nSVM: Remove NPT reserved bits tests (new one on the way) Sean Christopherson
2021-06-24 11:06 ` Paolo Bonzini
2021-06-24 17:43 ` Sean Christopherson
2021-06-24 17:47 ` Paolo Bonzini
2021-06-24 18:16 ` Sean Christopherson
2021-08-12 7:58 ` Maxim Levitsky
2021-06-22 21:00 ` [kvm-unit-tests PATCH 06/12] nSVM: Stop forcing EFER.NX=1 for all tests Sean Christopherson
2021-06-22 21:00 ` [kvm-unit-tests PATCH 07/12] nSVM: Remove a superfluous modification of guest EFER.NX in NPT NX test Sean Christopherson
2021-06-22 21:00 ` [kvm-unit-tests PATCH 08/12] nSVM: Clear guest's " Sean Christopherson
2021-06-22 21:00 ` [kvm-unit-tests PATCH 09/12] lib/vmalloc: Let arch code pass a value to its setup_mmu() helper Sean Christopherson
2021-06-22 21:00 ` [kvm-unit-tests PATCH 10/12] x86: Let tests omit PT_USER_MASK when configuring virtual memory Sean Christopherson
2021-06-22 21:00 ` [kvm-unit-tests PATCH 11/12] x86: Add GBPAGES CPUID macro, clean up CPUID comments Sean Christopherson
2021-06-22 21:00 ` [kvm-unit-tests PATCH 12/12] nSVM: Add test for NPT reserved bit and #NPF error code behavior Sean Christopherson
2021-06-23 11:52 ` Paolo Bonzini [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1b1dc5cf-f602-1ec9-2440-229c599dd7da@redhat.com \
--to=pbonzini@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=seanjc@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.