Re: [PATCH v10 vfio 0/7] pds_vfio driver

From: Brett Creeley <bcreeley@amd.com>
To: Brett Creeley <brett.creeley@amd.com>,
	kvm@vger.kernel.org, netdev@vger.kernel.org,
	alex.williamson@redhat.com, jgg@nvidia.com, yishaih@nvidia.com,
	shameerali.kolothum.thodi@huawei.com, kevin.tian@intel.com
Cc: shannon.nelson@amd.com
Subject: Re: [PATCH v10 vfio 0/7] pds_vfio driver
Date: Fri, 16 Jun 2023 21:49:05 -0700	[thread overview]
Message-ID: <1b5bb4df-df6f-65af-df05-08f1a4b3dacf@amd.com> (raw)
In-Reply-To: <20230602220318.15323-1-brett.creeley@amd.com>

On 6/2/2023 3:03 PM, Brett Creeley wrote:
> This is a patchset for a new vendor specific VFIO driver
> (pds_vfio) for use with the AMD/Pensando Distributed Services Card
> (DSC). This driver makes use of the pds_core driver.
> 
> This driver will use the pds_core device's adminq as the VFIO
> control path to the DSC. In order to make adminq calls, the VFIO
> instance makes use of functions exported by the pds_core driver.
> 
> In order to receive events from pds_core, the pds_vfio driver
> registers to a private notifier. This is needed for various events
> that come from the device.
> 
> An ASCII diagram of a VFIO instance looks something like this and can
> be used with the VFIO subsystem to provide the VF device VFIO and live
> migration support.
> 
>                                 .------.  .-----------------------.
>                                 | QEMU |--|  VM  .-------------.  |
>                                 '......'  |      |   Eth VF    |  |
>                                    |      |      .-------------.  |
>                                    |      |      |  SR-IOV VF  |  |
>                                    |      |      '-------------'  |
>                                    |      '------------||---------'
>                                 .--------------.       ||
>                                 |/dev/<vfio_fd>|       ||
>                                 '--------------'       ||
> Host Userspace                         |              ||
> ===================================================   ||
> Host Kernel                            |              ||
>                                    .--------.          ||
>                                    |vfio-pci|          ||
>                                    '--------'          ||
>         .------------------.           ||              ||
>         |   | exported API |<----+     ||              ||
>         |   '--------------|     |     ||              ||
>         |                  |    .-------------.        ||
>         |     pds_core     |--->|   pds_vfio  |        ||
>         '------------------' |  '-------------'        ||
>                 ||           |         ||              ||
>               09:00.0     notifier    09:00.1          ||
> == PCI ===============================================||=====
>                 ||                     ||              ||
>            .----------.          .----------.          ||
>      ,-----|    PF    |----------|    VF    |-------------------,
>      |     '----------'          '----------'  |       VF       |
>      |                     DSC                 |  data/control  |
>      |                                         |      path      |
>      -----------------------------------------------------------
> 
> 
> The pds_vfio driver is targeted to reside in drivers/vfio/pci/pds.
> It makes use of and introduces new files in the common include/linux/pds
> include directory.
> 
> Changes:
>  > v10:

Just as a quick note, I don't plan to push v11 next week as I am on 
vacation. I appreciate all the reviews and hope to have updates when I 
get back on the week of 6/26.

Thanks,

Brett

[...]