Re: [PATCH 4/6] SPI: S3C64XX: Check before mem-region release

From: jassi brar <jassisinghbrar-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
To: Grant Likely <grant.likely-s3s/WqlpOiPyB63q8FvJNQ@public.gmane.org>
Cc: spi-devel-general-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org,
	dbrownell-Rn4VEauK+AKRv+LV9MX5uipxlwaOVQ5f@public.gmane.org,
	ben-SMNkleLxa3Z6Wcw2j4pizdi2O/JbrIOy@public.gmane.org
Subject: Re: [PATCH 4/6] SPI: S3C64XX: Check before mem-region release
Date: Thu, 21 Jan 2010 10:35:11 +0900	[thread overview]
Message-ID: <1b68c6791001201735w3060c54blfa85b547917727c2@mail.gmail.com> (raw)
In-Reply-To: <1b68c6791001190152m652fd117k468893144af8dcfe-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>

On Tue, Jan 19, 2010 at 6:52 PM, jassi brar <jassisinghbrar@gmail.com> wrote:
> On Tue, Jan 19, 2010 at 11:32 AM, Grant Likely
> <grant.likely@secretlab.ca> wrote:
>> On Mon, Jan 18, 2010 at 4:42 PM, jassi brar <jassisinghbrar@gmail.com> wrote:
>>> On Tue, Jan 19, 2010 at 3:12 AM, Grant Likely <grant.likely@secretlab.ca> wrote:
>>>> On Mon, Jan 18, 2010 at 2:50 AM,  <jassisinghbrar@gmail.com> wrote:
>>>>> From: Jassi Brar <jassi.brar@samsung.com>
>>>>>
>>>>> Add precautionary check before releasing memory region.
>>>>>
>>>>> Signed-off-by: Jassi Brar <jassi.brar@samsung.com>
>>>>> ---
>>>>>  drivers/spi/spi_s3c64xx.c |    3 ++-
>>>>>  1 files changed, 2 insertions(+), 1 deletions(-)
>>>>>
>>>>> diff --git a/drivers/spi/spi_s3c64xx.c b/drivers/spi/spi_s3c64xx.c
>>>>> index 3acf381..0e883f9 100644
>>>>> --- a/drivers/spi/spi_s3c64xx.c
>>>>> +++ b/drivers/spi/spi_s3c64xx.c
>>>>> @@ -1097,7 +1097,8 @@ static int s3c64xx_spi_remove(struct platform_device *pdev)
>>>>>        iounmap((void *) sdd->regs);
>>>>>
>>>>>        mem_res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
>>>>> -       release_mem_region(mem_res->start, resource_size(mem_res));
>>>>> +       if (mem_res != NULL)
>>>>> +               release_mem_region(mem_res->start, resource_size(mem_res));
>>>>
>>>>
>>>> request_mem_region() in in an unconditional path in the .probe() hook.
>>>>  Are you seeing failure on the remove path?
>>> No failure, just warnings upon running some static code analyzer.
>>
>> Okay.  For future reference, it makes my job easier (and more likely
>> that I'll pick up the patch) if the commit log states why a change is
>> being made, and not just what.
> Ok, will take care in future. Thanks.
Hi Grant Likely,
 You have reviewed this series of patches but didn't ACK/NAK.
Could you kindly confirm if u accept them or want some changes?
Thanks.

------------------------------------------------------------------------------
Throughout its 18-year history, RSA Conference consistently attracts the
world's best and brightest in the field, creating opportunities for Conference
attendees to learn about information security's most important issues through
interactions with peers, luminaries and emerging and established companies.
http://p.sf.net/sfu/rsaconf-dev2dev
_______________________________________________
spi-devel-general mailing list
spi-devel-general@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/spi-devel-general