Re: [PATCH] rtl8193: switch to use qemu_receive_packet() for loopback

From: Jason Wang <jasowang@redhat.com>
To: Alexander Bulekov <alxndr@bu.edu>
Cc: "open list:All patches CC here" <qemu-devel@nongnu.org>,
	ppandit@redhat.com
Subject: Re: [PATCH] rtl8193: switch to use qemu_receive_packet() for loopback
Date: Mon, 1 Mar 2021 15:14:51 +0800	[thread overview]
Message-ID: <1b9c555d-e271-b826-7f7f-1b0344abc35d@redhat.com> (raw)
In-Reply-To: <20210226184753.230037-1-alxndr@bu.edu>

On 2021/2/27 2:47 上午, Alexander Bulekov wrote:
> This patch switches to use qemu_receive_packet() which can detect
> reentrancy and return early.
>
> Buglink: https://bugs.launchpad.net/qemu/+bug/1910826
> Signed-off-by: Alexander Bulekov <alxndr@bu.edu>
> ---
>
> Although it's not a nc->info->receive() call, maybe this can also go in
> this series?
>
> -Alex

Yes, I will add this in this series.

Thanks

>
>   hw/net/rtl8139.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/net/rtl8139.c b/hw/net/rtl8139.c
> index 4675ac878e..90b4fc63ce 100644
> --- a/hw/net/rtl8139.c
> +++ b/hw/net/rtl8139.c
> @@ -1795,7 +1795,7 @@ static void rtl8139_transfer_frame(RTL8139State *s, uint8_t *buf, int size,
>           }
>   
>           DPRINTF("+++ transmit loopback mode\n");
> -        rtl8139_do_receive(qemu_get_queue(s->nic), buf, size, do_interrupt);
> +        qemu_receive_packet(qemu_get_queue(s->nic), buf, size);
>   
>           if (iov) {
>               g_free(buf2);