Re: [RFC 0/2] iio: accel: mxc4005: IRQ fixes + reset chip on probe()

From: Hans de Goede <hdegoede@redhat.com>
To: Jonathan Cameron <jic23@kernel.org>
Cc: Lars-Peter Clausen <lars@metafoo.de>,
	Christian Oder <me@myself5.de>,
	Nikita Mikhailevich <ermyril@gmail.com>,
	linux-iio@vger.kernel.org
Subject: Re: [RFC 0/2] iio: accel: mxc4005: IRQ fixes + reset chip on probe()
Date: Wed, 27 Mar 2024 12:02:02 +0100	[thread overview]
Message-ID: <1cff2613-b403-4585-a51d-5468afc13a98@redhat.com> (raw)
In-Reply-To: <20240326113700.56725-1-hdegoede@redhat.com>

Hi,

On 3/26/24 12:36 PM, Hans de Goede wrote:
> Hi All,
> 
> As reported here:
> https://bugzilla.kernel.org/show_bug.cgi?id=218578
> 
> The MXC6655 found on several Chuwi tablets models works sometimes instead
> of all the time. The problem seems to be that the power-sequencing done
> on the board causes the chip to not reliably reset leaving it in a random
> state at boot (and after suspend/resume).
> 
> The second patch in this set fixes this by using the sw-reset feature to
> explicitly reset the chip on probe() and resume().
> 
> While working on this I also noticed an issue with the interrupt mask
> handling, this is fixed in the first patch of the set.
> 
> This is marked as a RFC for now because this is untested atm. I'll
> provide a test kernel to the reporter of:
> https://bugzilla.kernel.org/show_bug.cgi?id=218578
> so that this can be tested.

This has been tested now and works as advertised so from
my POV this is ready for merging now and no longer has
RFC status.

Regards,

Hans

> Hans de Goede (2):
>   iio: accel: mxc4005: Interrupt handling fixes
>   iio: accel: mxc4005: Reset chip on probe() and resume()
> 
>  drivers/iio/accel/mxc4005.c | 82 +++++++++++++++++++++++++++++++++----
>  1 file changed, 75 insertions(+), 7 deletions(-)
> 