From: Samuel Zou <zou_wei@huawei.com>
To: shuah <shuah@kernel.org>, <trenn@suse.com>
Cc: <linux-pm@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH -next] cpupower: Remove unneeded semicolon
Date: Wed, 6 May 2020 08:52:15 +0800 [thread overview]
Message-ID: <1d1333ae-6d7f-a456-567b-34852270000b@huawei.com> (raw)
In-Reply-To: <a51e2f2b-3381-bd5d-9599-0f291520b272@kernel.org>
Hi Shuah,
I run with the below command, and get the output report.
[local-host linux-next]# make coccicheck MODE=report
M=tools/power/cpupower/utils
Please check for false positives in the output before submitting a patch.
When using "patch" mode, carefully review the patch before submitting it.
tools/power/cpupower/utils/idle_monitor/cpuidle_sysfs.c:175:2-3:
Unneeded semicolon
tools/power/cpupower/utils/idle_monitor/cpuidle_sysfs.c:56:2-3: Unneeded
semicolon
tools/power/cpupower/utils/idle_monitor/cpuidle_sysfs.c:75:2-3: Unneeded
semicolon
tools/power/cpupower/utils/idle_monitor/snb_idle.c:80:2-3: Unneeded
semicolon
tools/power/cpupower/utils/cpupower-set.c:75:2-3: Unneeded semicolon
tools/power/cpupower/utils/idle_monitor/hsw_ext_idle.c:82:2-3: Unneeded
semicolon
tools/power/cpupower/utils/idle_monitor/amd_fam14h_idle.c:120:2-3:
Unneeded semicolon
tools/power/cpupower/utils/idle_monitor/nhm_idle.c:94:2-3: Unneeded
semicolon
tools/power/cpupower/utils/cpupower-info.c:65:2-3: Unneeded semicolon
On 2020/5/2 1:07, shuah wrote:
> Hi Zou Wei,
>
> On 4/28/20 3:43 AM, Zou Wei wrote:
>> Fixes coccicheck warnings:
>
> I am not finding these in my coccicheck run. Can you send me the options
> you are using?
>
>>
>> tools/power/cpupower/utils/cpupower-info.c:65:2-3: Unneeded semicolon
>> tools/power/cpupower/utils/cpupower-set.c:75:2-3: Unneeded semicolon
>> tools/power/cpupower/utils/idle_monitor/amd_fam14h_idle.c:120:2-3:
>> Unneeded semicolon
>> tools/power/cpupower/utils/idle_monitor/cpuidle_sysfs.c:175:2-3:
>> Unneeded semicolon
>> tools/power/cpupower/utils/idle_monitor/cpuidle_sysfs.c:56:2-3:
>> Unneeded semicolon
>> tools/power/cpupower/utils/idle_monitor/cpuidle_sysfs.c:75:2-3:
>> Unneeded semicolon
>> tools/power/cpupower/utils/idle_monitor/hsw_ext_idle.c:82:2-3:
>> Unneeded semicolon
>> tools/power/cpupower/utils/idle_monitor/nhm_idle.c:94:2-3: Unneeded
>> semicolon
>> tools/power/cpupower/utils/idle_monitor/snb_idle.c:80:2-3: Unneeded
>> semicolon
>>
>> Reported-by: Hulk Robot <hulkci@huawei.com>
>> Signed-off-by: Zou Wei <zou_wei@huawei.com>
>> ---
>> tools/power/cpupower/utils/cpupower-info.c | 2 +-
>> tools/power/cpupower/utils/cpupower-set.c | 2 +-
>> tools/power/cpupower/utils/idle_monitor/amd_fam14h_idle.c | 2 +-
>> tools/power/cpupower/utils/idle_monitor/cpuidle_sysfs.c | 6 +++---
>> tools/power/cpupower/utils/idle_monitor/hsw_ext_idle.c | 2 +-
>> tools/power/cpupower/utils/idle_monitor/nhm_idle.c | 2 +-
>> tools/power/cpupower/utils/idle_monitor/snb_idle.c | 2 +-
>> 7 files changed, 9 insertions(+), 9 deletions(-)
>>
>> diff --git a/tools/power/cpupower/utils/cpupower-info.c
>> b/tools/power/cpupower/utils/cpupower-info.c
>> index d3755ea..0ba61a2 100644
>> --- a/tools/power/cpupower/utils/cpupower-info.c
>> +++ b/tools/power/cpupower/utils/cpupower-info.c
>> @@ -62,7 +62,7 @@ int cmd_info(int argc, char **argv)
>> default:
>> print_wrong_arg_exit();
>> }
>> - };
>> + }
>
> The patch itself is fine.
>
> thanks,
> -- Shuah
>
> .
next prev parent reply other threads:[~2020-05-06 0:52 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-28 9:43 [PATCH -next] cpupower: Remove unneeded semicolon Zou Wei
2020-05-01 17:07 ` shuah
2020-05-06 0:52 ` Samuel Zou [this message]
2020-05-06 16:09 ` shuah
2020-05-13 1:42 ` shuah
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1d1333ae-6d7f-a456-567b-34852270000b@huawei.com \
--to=zou_wei@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=shuah@kernel.org \
--cc=trenn@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.