From: Marc Kleine-Budde <mkl@pengutronix.de>
To: Torin Cooper-Bennun <torin@maxiluxsystems.com>,
linux-can@vger.kernel.org
Cc: Mariusz Madej <mariusz.madej@xtrack.com>
Subject: Re: [PATCH] can: m_can: m_can_do_rx_poll(): fix extraneous msg loss warning
Date: Thu, 4 Mar 2021 14:22:32 +0100 [thread overview]
Message-ID: <1db40663-a9d0-5431-3453-95076f6846c5@pengutronix.de> (raw)
In-Reply-To: <20210303103151.3760532-1-torin@maxiluxsystems.com>
[-- Attachment #1.1: Type: text/plain, Size: 853 bytes --]
On 3/3/21 11:31 AM, Torin Cooper-Bennun wrote:
> Message loss from RX FIFO 0 is already handled in m_can_handle_lost_msg,
> with netdev output included.
>
> Removing this warning also improves driver performance under heavy load,
> where m_can_do_rx_poll may be called many times before this interrupt is
> cleared, causing this message to be output many times (thanks Mariusz
> Madej for this report).
>
> Cc: Mariusz Madej <mariusz.madej@xtrack.com>
> Signed-off-by: Torin Cooper-Bennun <torin@maxiluxsystems.com>
Applied to linux-can/testing.
regards,
Marc
--
Pengutronix e.K. | Marc Kleine-Budde |
Embedded Linux | https://www.pengutronix.de |
Vertretung West/Dortmund | Phone: +49-231-2826-924 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
prev parent reply other threads:[~2021-03-04 13:24 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-03 10:31 [PATCH] can: m_can: m_can_do_rx_poll(): fix extraneous msg loss warning Torin Cooper-Bennun
2021-03-04 13:22 ` Marc Kleine-Budde [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1db40663-a9d0-5431-3453-95076f6846c5@pengutronix.de \
--to=mkl@pengutronix.de \
--cc=linux-can@vger.kernel.org \
--cc=mariusz.madej@xtrack.com \
--cc=torin@maxiluxsystems.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.