Re: [PATCH] engines/io_uring_cmd: skip pi verify checks for error cases

From: Vincent Fu <vincentfu@gmail.com>
To: Ankit Kumar <ankit.kumar@samsung.com>, axboe@kernel.dk
Cc: fio@vger.kernel.org
Subject: Re: [PATCH] engines/io_uring_cmd: skip pi verify checks for error cases
Date: Tue, 12 Dec 2023 09:40:51 -0500	[thread overview]
Message-ID: <1dd0e64e-029e-4689-a6c3-b2e0e5228dae@gmail.com> (raw)
In-Reply-To: <20231212144718.568406-1-ankit.kumar@samsung.com>

On 12/12/23 09:47, Ankit Kumar wrote:
> If any error is observed for read requests, skip all end to end data
> protection checks.
> 
> Signed-off-by: Ankit Kumar <ankit.kumar@samsung.com>
> ---
>   engines/io_uring.c | 6 ++++--
>   1 file changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/engines/io_uring.c b/engines/io_uring.c
> index 5ae3135b..c0cb5a78 100644
> --- a/engines/io_uring.c
> +++ b/engines/io_uring.c
> @@ -468,10 +468,12 @@ static struct io_u *fio_ioring_cmd_event(struct thread_data *td, int event)
>   	cqe = &ld->cq_ring.cqes[index];
>   	io_u = (struct io_u *) (uintptr_t) cqe->user_data;
>   
> -	if (cqe->res != 0)
> +	if (cqe->res != 0) {
>   		io_u->error = -cqe->res;
> -	else
> +		return io_u;
> +	} else {
>   		io_u->error = 0;
> +	}
>   
>   	if (o->cmd_type == FIO_URING_CMD_NVME) {
>   		data = FILE_ENG_DATA(io_u->file);

Applied. Thanks.