Re: [Qemu-devel] [PULL v2 0/9] Ide patches

From: John Snow <jsnow@redhat.com>
To: qemu-devel@nongnu.org
Cc: famz@redhat.com, peter.maydell@linaro.org
Subject: Re: [Qemu-devel] [PULL v2 0/9] Ide patches
Date: Mon, 14 Nov 2016 12:01:59 -0500	[thread overview]
Message-ID: <1e656ae0-e558-e096-730b-2a5853a7c935@redhat.com> (raw)
In-Reply-To: <147914275667.238.7399833850728779563@9040ca97f87d>

On 11/14/2016 11:59 AM, no-reply@patchew.org wrote:
> Hi,
>
> Your series seems to have some coding style problems. See output below for
> more information:
>

All failures below are intentional deviations.

> Type: series
> Subject: [Qemu-devel] [PULL v2 0/9] Ide patches
> Message-id: 1479140746-22142-1-git-send-email-jsnow@redhat.com
>
> === TEST SCRIPT BEGIN ===
> #!/bin/bash
>
> BASE=base
> n=1
> total=$(git log --oneline $BASE.. | wc -l)
> failed=0
>
> # Useful git options
> git config --local diff.renamelimit 0
> git config --local diff.renames True
>
> commits="$(git log --format=%H --reverse $BASE..)"
> for c in $commits; do
>     echo "Checking PATCH $n/$total: $(git show --no-patch --format=%s $c)..."
>     if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
>         failed=1
>         echo
>     fi
>     n=$((n+1))
> done
>
> exit $failed
> === TEST SCRIPT END ===
>
> Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
> From https://github.com/patchew-project/qemu
>  * [new tag]         patchew/1479140746-22142-1-git-send-email-jsnow@redhat.com -> patchew/1479140746-22142-1-git-send-email-jsnow@redhat.com
> Switched to a new branch 'test'
> aac853f ahci-test: add QMP tray test for ATAPI
> 9aff593 libqos/ahci: Add get_sense and test_ready
> 7163df5 libqos/ahci: Add ATAPI tray macros
> f1e2266 libqos/ahci: Support expected errors
> 3968b94 libqtest: add qmp_eventwait_ref
> 9d13ef0 block-backend: Always notify on blk_eject
> 341ba04 ahci-test: test atapi read_cd with bcl, nb_sectors = 0
> 8990ba8 ahci-test: Create smaller test ISO images
> e3e34c1 atapi: classify read_cd as conditionally returning data
>
> === OUTPUT BEGIN ===
> fatal: unrecognized argument: --no-patch
> Checking PATCH 1/9: ...
> ERROR: space prohibited after that open square bracket '['
> #92: FILE: hw/ide/atapi.c:1324:
> +    [ 0xbe ] = { cmd_read_cd,                       CHECK_READY | CONDDATA },
>
> ERROR: space prohibited before that close square bracket ']'
> #92: FILE: hw/ide/atapi.c:1324:
> +    [ 0xbe ] = { cmd_read_cd,                       CHECK_READY | CONDDATA },
>
> total: 2 errors, 0 warnings, 86 lines checked
>

This is intentional and won't change, at least not for this patch. If we 
truly want to restructure the command table, I can -- but another time.

--js

> Your patch has style problems, please review.  If any of these errors
> are false positives report them to the maintainer, see
> CHECKPATCH in MAINTAINERS.
>
> fatal: unrecognized argument: --no-patch
> Checking PATCH 2/9: ...
> fatal: unrecognized argument: --no-patch
> Checking PATCH 3/9: ...
> fatal: unrecognized argument: --no-patch
> Checking PATCH 4/9: ...
> fatal: unrecognized argument: --no-patch
> Checking PATCH 5/9: ...
> fatal: unrecognized argument: --no-patch
> Checking PATCH 6/9: ...
> fatal: unrecognized argument: --no-patch
> Checking PATCH 7/9: ...
> fatal: unrecognized argument: --no-patch
> Checking PATCH 8/9: ...
> fatal: unrecognized argument: --no-patch
> Checking PATCH 9/9: ...
> === OUTPUT END ===
>
> Test command exited with code: 1
>
>
> ---
> Email generated automatically by Patchew [http://patchew.org/].
> Please send your feedback to patchew-devel@freelists.org
>