From: Julien Grall <julien@xen.org>
To: Ian Jackson <iwj@xenproject.org>, Wei Liu <wl@xen.org>
Cc: xen-devel@lists.xenproject.org, Jan Beulich <jbeulich@suse.com>,
Anthony PERARD <anthony.perard@citrix.com>
Subject: Re: PING Re: [XEN PATCH] libs/foreignmemory: Fix osdep_xenforeignmemory_map prototype
Date: Tue, 15 Jun 2021 19:12:30 +0200 [thread overview]
Message-ID: <1eed05e4-958c-c724-67dc-266cc0011c94@xen.org> (raw)
In-Reply-To: <d80b6904-ff5c-33d6-b0e3-6882fe3e8e89@xen.org>
Hi,
On 15/06/2021 15:31, Julien Grall wrote:
> Hi Ian & Wei,
>
> On 02/06/2021 10:25, Jan Beulich wrote:
>> On 01.06.2021 17:41, Anthony PERARD wrote:
>>> Commit cf8c4d3d13b8 made some preparation to have one day
>>> variable-length-array argument, but didn't declare the array in the
>>> function prototype the same way as in the function definition. And now
>>> GCC 11 complains about it.
>>>
>>> Fixes: cf8c4d3d13b8 ("tools/libs/foreignmemory: pull array length
>>> argument to map forward")
>>> Signed-off-by: Anthony PERARD <anthony.perard@citrix.com>
>>
>> Reviewed-by: Jan Beulich <jbeulich@suse.com>
>>
>> Ian - this (or whichever alternative might be chosen to address gcc11's
>> valid complaint) also will want backporting.
>
> I was about to commit this patch and noticed that there is still a
> missing an ack from the tools maintainers. @Ian, @Wei, can you provide one?
From an IRC discussion, Ian was happy to follow the rule:
"Commit something without the necessary acks if you're reasonably
certain that the maintainer would have approved it"
This doesn't seem to be part of MAINTAINERS, but I will use it for this
patch as Ian gave his assent.
This is committed now.
Cheers,
--
Julien Grall
prev parent reply other threads:[~2021-06-15 17:12 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-01 15:41 [XEN PATCH] libs/foreignmemory: Fix osdep_xenforeignmemory_map prototype Anthony PERARD
2021-06-02 8:25 ` Jan Beulich
2021-06-15 13:31 ` PING " Julien Grall
2021-06-15 17:12 ` Julien Grall [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1eed05e4-958c-c724-67dc-266cc0011c94@xen.org \
--to=julien@xen.org \
--cc=anthony.perard@citrix.com \
--cc=iwj@xenproject.org \
--cc=jbeulich@suse.com \
--cc=wl@xen.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.