All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andi Kleen <andi@firstfloor.org>
To: Sam Ravnborg <sam@ravnborg.org>
Cc: Andi Kleen <andi@firstfloor.org>,
	linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] KBUILD: Create the source symlink earlier in the objdir
Date: Sun, 15 Feb 2009 12:16:08 +0100	[thread overview]
Message-ID: <20090215111608.GE26292@one.firstfloor.org> (raw)
In-Reply-To: <20090215103659.GC31088@uranus.ravnborg.org>

> diff --git a/Makefile b/Makefile
> index 22d7584..76ee131 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -388,6 +388,7 @@ PHONY += outputmakefile
>  # separate output directory. This allows convenient use of make in the
>  # output directory.
>  outputmakefile:
> +	$(Q)ln -fsn $(srctree) source
>  ifneq ($(KBUILD_SRC),)

Haven't tried it, but
doesn't that create the symlink in the non separate objdir case too
because it's outside the ifneq?

>  	$(Q)$(CONFIG_SHELL) $(srctree)/scripts/mkmakefile \
>  	    $(srctree) $(objtree) $(VERSION) $(PATCHLEVEL)
> @@ -946,7 +947,6 @@ ifneq ($(KBUILD_SRC),)
>  	    mkdir -p include2;                                          \
>  	    ln -fsn $(srctree)/include/asm-$(SRCARCH) include2/asm;     \
>  	fi
> -	ln -fsn $(srctree) source
>  endif

-Andi

-- 
ak@linux.intel.com -- Speaking for myself only.

  reply	other threads:[~2009-02-15 10:59 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-01-10  3:56 [PATCH] KBUILD: Create the source symlink earlier in the objdir Andi Kleen
2009-02-15 10:36 ` Sam Ravnborg
2009-02-15 11:16   ` Andi Kleen [this message]
2009-02-15 11:41     ` Sam Ravnborg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090215111608.GE26292@one.firstfloor.org \
    --to=andi@firstfloor.org \
    --cc=linux-kbuild@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sam@ravnborg.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.