From: Paul Mundt <lethal@linux-sh.org>
To: linux-sh@vger.kernel.org
Subject: Re: [PATCH v2] sh: Update dma-sh api
Date: Tue, 10 Mar 2009 07:23:52 +0000 [thread overview]
Message-ID: <20090310072352.GG10393@linux-sh.org> (raw)
In-Reply-To: <49B5D5E4.4060801@renesas.com>
On Tue, Mar 10, 2009 at 04:22:37PM +0900, Nobuhiro Iwamatsu wrote:
> Paul Mundt wrote:
> >On Tue, Mar 10, 2009 at 01:48:14PM +0900, Nobuhiro Iwamatsu wrote:
> >>diff --git a/arch/sh/include/asm/dma.h b/arch/sh/include/asm/dma.h
> >>index beca712..085e05a 100644
> >>--- a/arch/sh/include/asm/dma.h
> >>+++ b/arch/sh/include/asm/dma.h
> >>@@ -23,12 +23,8 @@
> >> /* But... */
> >> /* XXX: This is not applicable to SuperH, just needed for alloc_bootmem
> >> */
> >> #define MAX_DMA_ADDRESS (PAGE_OFFSET+0x10000000)
> >>-
> >>-#ifdef CONFIG_NR_DMA_CHANNELS
> >>-# define MAX_DMA_CHANNELS (CONFIG_NR_DMA_CHANNELS)
> >>-#else
> >>-# define MAX_DMA_CHANNELS (CONFIG_NR_ONCHIP_DMA_CHANNELS)
> >>-#endif
> >>+/* MAX DMA Channel */
> >>+#define MAX_DMA_CHANNELS (CONFIG_NR_ONCHIP_DMA_CHANNELS)
>
> Thank you for your comments.
>
>
> >>
> >This breaks the Dreamcast, which contains multiple DMACs and needs more
> >than the on-chip channels managed by the DMA API. As the Dreamcast is the
> >primary user of this code, please make sure you do not break its use of
> >the API. It would also be good if someone can verify whether the G2 and
> >PVR2 DMA still work after this patch is applied.
>
> OK. I will fix this point.
> >
> >On the other hand, I don't know how much we really want to be doing here
> >in the first place. All new development should be happening on the
> >dmaengine API instead, this code is mostly for keeping the existing users
> >limping along, and not much else. Matt Fleming was doing some work there,
> >it would be preferable to see that code updated and merged rather than
> >work spent on the old DMA API.
> >
>
> I see.
> I have already been writing the driver of DMAengine, and I am testing.
> To make old DMA-API coexist with dma engine in these patches, I wrote.
>
Ah, ok, I wasn't aware that that was what your intention was. In that
case, once the Dreamcast fallout is fixed, I'll merge these.
next prev parent reply other threads:[~2009-03-10 7:23 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-10 2:52 [PATCH v2] sh: Update dma-sh api Nobuhiro Iwamatsu
2009-03-10 4:48 ` Nobuhiro Iwamatsu
2009-03-10 6:02 ` Paul Mundt
2009-03-10 7:22 ` Nobuhiro Iwamatsu
2009-03-10 7:23 ` Paul Mundt [this message]
2009-03-13 12:05 ` Adrian McMenamin
2009-03-13 15:09 ` Paul Mundt
2009-03-14 1:12 ` Adrian McMenamin
2009-03-16 2:18 ` Nobuhiro Iwamatsu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090310072352.GG10393@linux-sh.org \
--to=lethal@linux-sh.org \
--cc=linux-sh@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.