From: Russell King - ARM Linux <linux@arm.linux.org.uk>
To: Atal Shargorodsky <ext-atal.shargorodsky@nokia.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/7] OMAP: watchdog driver fixes.
Date: Tue, 10 Mar 2009 23:30:32 +0000 [thread overview]
Message-ID: <20090310233032.GC26045@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <1236701036-19942-1-git-send-email-ext-atal.shargorodsky@nokia.com>
On Tue, Mar 10, 2009 at 06:03:50PM +0200, Atal Shargorodsky wrote:
> This patchset reorganizes slightly the code of omap_wdt driver,
> introduces proper management of clocks and
> CONFIG_WATCHDOG_NOWAYOUT + PM support, which was broken.
> Also, inspired by numerous watchdog drivers using this technique,
> this patchset makes the NOWAYOUT behavior not to be restricted by kernel
> configuration, but to be controlled by a module parameter.
NAK for the entire patch set. The first four patches severely clash
with my clk API work which is (in theory) queued for the next merge
window. My patches already eliminate most of the unnecessary clk API
crap in there.
Moreover, your emails show no interaction with either the ARM mailing
lists or the OMAP mailing lists.
Please submit your patches to both the ARM and OMAP mailing lists for
review there. Thanks.
next prev parent reply other threads:[~2009-03-10 23:30 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-10 16:03 [PATCH 0/7] OMAP: watchdog driver fixes Atal Shargorodsky
2009-03-10 16:03 ` [PATCH 1/6] Remove armwdt_ck field from omap_wdt_dev structure Atal Shargorodsky
2009-03-10 16:03 ` [PATCH 2/6] Fix interface clock existance check Atal Shargorodsky
2009-03-10 16:03 ` [PATCH 3/6] Remove non-explanatory comments Atal Shargorodsky
2009-03-10 16:03 ` [PATCH 4/6] Proper interface clock management Atal Shargorodsky
2009-03-10 16:03 ` [PATCH 5/6] Correct manage of activation states Atal Shargorodsky
2009-03-10 16:03 ` [PATCH 6/6] Changing NOWAYOUT behavior does not require kernel reconfiguration Atal Shargorodsky
2009-03-11 15:29 ` [PATCH 6/6] OMAP: omap_wdt: " Atal Shargorodsky
2009-03-11 15:29 ` [PATCH 5/6] OMAP: omap_wdt: Correct manage of activation states Atal Shargorodsky
2009-03-11 15:29 ` [PATCH 4/6] OMAP: omap_wdt: Proper interface clock management Atal Shargorodsky
2009-03-11 15:29 ` [PATCH 3/6] OMAP: omap_wdt: Remove non-explanatory comments Atal Shargorodsky
2009-03-11 15:29 ` [PATCH 2/6] OMAP: omap_wdt: Fix interface clock existence check Atal Shargorodsky
2009-03-11 16:02 ` [PATCH 1/6] OMAP: omap_wdt: Remove armwdt_ck field from omap_wdt_dev structure Tony Lindgren
2009-03-10 23:30 ` Russell King - ARM Linux [this message]
2009-03-11 15:29 [PATCH 0/6] OMAP: omap_wdt: clocks and NOWAYOUT fixes Atal Shargorodsky
2009-03-11 15:29 ` [PATCH 1/6] OMAP: omap_wdt: Remove armwdt_ck field from omap_wdt_dev structure Atal Shargorodsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090310233032.GC26045@n2100.arm.linux.org.uk \
--to=linux@arm.linux.org.uk \
--cc=ext-atal.shargorodsky@nokia.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.