From: Christoph Hellwig <hch@infradead.org>
To: Jeff Layton <jlayton@redhat.com>
Cc: linux-cifs-client@lists.samba.org, linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH 06/13] cifs: add new cifs_iget function and convert unix codepath to use it
Date: Wed, 27 May 2009 09:23:32 -0400 [thread overview]
Message-ID: <20090527132332.GA5938@infradead.org> (raw)
In-Reply-To: <1243427434-6498-7-git-send-email-jlayton@redhat.com>
On Wed, May 27, 2009 at 08:30:27AM -0400, Jeff Layton wrote:
> In order to unify some codepaths, introduce a common cifs_fattr struct
> for storing inode attributes. The different codepaths (unix, legacy,
> normal, etc...) can fill out this struct with inode info. It can then
> be passed as an arg to a common set of routines to get and update inodes.
>
> Add a new cifs_iget function that uses iget5_locked to identify inodes.
> This will compare inodes based on the uniqueid value in a cifs_fattr
> struct.
>
> Rather than filling out an already-created inode, have
> cifs_get_inode_info_unix instead fill out cifs_fattr and hand that off
> to cifs_iget. cifs_iget can then properly look for hardlinked inodes.
>
> With this, we should then have proper hardlink detection and can
> eventually get rid of some nasty CIFS-specific hacks for handing them.
>
> Fixing the unix readdir codepath will be done in a later patch.
Looks good to me:
Reviewed-by: Christoph Hellwig <hch@lst.de>
next prev parent reply other threads:[~2009-05-27 13:23 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-27 12:30 [PATCH 00/13] cifs: implement proper hardlink handling (try #4) Jeff Layton
2009-05-27 12:30 ` [PATCH 01/13] cifs: have cifs_NTtimeToUnix take a little-endian arg Jeff Layton
2009-05-27 12:30 ` [PATCH 02/13] cifs: make cnvrtDosUnixTm take a little-endian args and an offset Jeff Layton
2009-05-27 12:30 ` [PATCH 03/13] cifs: reorganize get_cifs_acl Jeff Layton
2009-05-27 12:30 ` [PATCH 04/13] cifs: clean up set_cifs_acl interfaces Jeff Layton
2009-05-27 12:30 ` [PATCH 05/13] cifs: rename cifs_iget to cifs_root_iget Jeff Layton
2009-05-27 12:30 ` [PATCH 06/13] cifs: add new cifs_iget function and convert unix codepath to use it Jeff Layton
2009-05-27 13:23 ` Christoph Hellwig [this message]
2009-05-27 12:30 ` [PATCH 07/13] cifs: convert posix readdir codepath to use cifs_iget Jeff Layton
2009-05-27 13:36 ` Christoph Hellwig
2009-05-27 13:42 ` Jeff Layton
2009-05-27 12:30 ` [PATCH 08/13] cifs: convert cifs_get_inode_info " Jeff Layton
2009-05-27 13:40 ` Christoph Hellwig
2009-05-27 14:13 ` Jeff Layton
2009-05-27 12:30 ` [PATCH 09/13] cifs: convert non-posix readdir codepath " Jeff Layton
2009-05-27 13:44 ` Christoph Hellwig
2009-05-27 12:30 ` [PATCH 10/13] cifs: remove cifs_new_inode Jeff Layton
2009-05-27 13:45 ` Christoph Hellwig
2009-05-27 12:30 ` [PATCH 11/13] cifs: make serverino the default when mounting Jeff Layton
2009-05-27 12:30 ` [PATCH 12/13] cifs: remove cifsInodeInfo->inUse counter Jeff Layton
2009-05-27 13:45 ` Christoph Hellwig
2009-05-27 12:30 ` [PATCH 13/13] cifs: remove "hardlink detection" from cifs_rename Jeff Layton
-- strict thread matches above, loose matches on Subject: below --
2009-05-13 20:04 [PATCH 00/13] cifs: implement proper hardlink detection (try #3) Jeff Layton
2009-05-13 20:04 ` [PATCH 06/13] cifs: add new cifs_iget function and convert unix codepath to use it Jeff Layton
2009-05-11 20:24 [PATCH 00/13] cifs: implement proper hardlink detection Jeff Layton
2009-05-11 20:24 ` [PATCH 06/13] cifs: add new cifs_iget function and convert unix codepath to use it Jeff Layton
2009-05-11 21:06 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090527132332.GA5938@infradead.org \
--to=hch@infradead.org \
--cc=jlayton@redhat.com \
--cc=linux-cifs-client@lists.samba.org \
--cc=linux-fsdevel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.