From: Eduardo Valentin <eduardo.valentin@nokia.com>
To: ext Douglas Schilling Landgraf <dougsland@gmail.com>
Cc: "Valentin Eduardo (Nokia-D/Helsinki)"
<eduardo.valentin@nokia.com>, Hans Verkuil <hverkuil@xs4all.nl>,
Mauro Carvalho Chehab <mchehab@infradead.org>,
"Nurkkala Eero.An (EXT-Offcode/Oulu)"
<ext-Eero.Nurkkala@nokia.com>,
"linux-media@vger.kernel.org" <linux-media@vger.kernel.org>
Subject: Re: [PATCHv4 0 of 8] FM Transmitter (si4713) and another changes
Date: Fri, 29 May 2009 09:03:59 +0300 [thread overview]
Message-ID: <20090529060359.GC12102@esdhcp037198.research.nokia.com> (raw)
In-Reply-To: <20090529023620.7497f10d@gmail.com>
Hi Douglas,
On Fri, May 29, 2009 at 07:36:20AM +0200, ext Douglas Schilling Landgraf wrote:
> Hello Eduardo,
>
> On Wed, 27 May 2009 12:35:47 +0300
> Eduardo Valentin <eduardo.valentin@nokia.com> wrote:
>
> > Hello all,
> >
> > I'm resending the FM transmitter driver and the proposed changes in
> > v4l2 api files in order to cover the fmtx extended controls class.
> >
> > It is basically the same series of version #3. However I rewrote it
> > to add the following comments:
> >
> > * Check kernel version for i2c helper function. Now the board data
> > is passed not using i2c_board_info. This way all supported kernel
> > versions can use the api. Besides that, the .s_config callback was
> > added in core ops.
> >
> > * All patches are against v4l-dvb hg repository.
> >
> > Again, comments are welcome.
>
>
> I have a comment, please check some headers to avoid errors.
>
> Instead of:
>
> patch 05:
>
> #include <media/linux/v4l2-device.h>
> #include <media/linux/v4l2-ioctl.h>
> #include <media/linux/v4l2-i2c-drv.h>
> #include <media/linux/v4l2-subdev.h>
>
> patch 06:
>
> #include <media/linux/v4l2-device.h>
> #include <media/linux/v4l2-common.h>
> #include <media/linux/v4l2-ioctl.h>
>
> Please use:
>
> #include <media/v4l2-device.h>
> #include <media/v4l2-ioctl.h>
> #include <media/v4l2-i2c-drv.h>
> #include <media/v4l2-subdev.h>
>
> and
>
> #include <media/v4l2-device.h>
> #include <media/v4l2-common.h>
> #include <media/v4l2-ioctl.h>
Right, I'll re send it.
Thanks for reviewing.
>
> Cheers,
> Douglas
--
Eduardo Valentin
next prev parent reply other threads:[~2009-05-29 6:08 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-27 9:35 [PATCHv4 0 of 8] FM Transmitter (si4713) and another changes Eduardo Valentin
2009-05-27 9:35 ` [PATCHv4 1 of 8] v4l2_subdev i2c: Add v4l2_i2c_new_subdev_board i2c helper function Eduardo Valentin
2009-05-27 9:35 ` [PATCHv4 2 of 8] v4l2: video device: Add V4L2_CTRL_CLASS_FMTX controls Eduardo Valentin
2009-05-27 9:35 ` [PATCHv4 3 of 8] v4l2: video device: Add FMTX controls default configurations Eduardo Valentin
2009-05-27 9:35 ` [PATCHv4 4 of 8] Add documentation description for FM Transmitter Extended Control Class Eduardo Valentin
2009-05-27 9:35 ` [PATCHv4 5 of 8] FMTx: si4713: Add files to handle si4713 i2c device Eduardo Valentin
2009-05-27 9:35 ` [PATCHv4 6 of 8] FMTx: si4713: Add files to add radio interface for si4713 Eduardo Valentin
2009-05-27 9:35 ` [PATCHv4 7 of 8] FMTx: si4713: Add Kconfig and Makefile entries Eduardo Valentin
2009-05-27 9:35 ` [PATCHv4 8 of 8] FMTx: si4713: Add document file Eduardo Valentin
2009-05-29 5:36 ` [PATCHv4 0 of 8] FM Transmitter (si4713) and another changes Douglas Schilling Landgraf
2009-05-29 6:03 ` Eduardo Valentin [this message]
2009-05-29 6:13 ` Eduardo Valentin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090529060359.GC12102@esdhcp037198.research.nokia.com \
--to=eduardo.valentin@nokia.com \
--cc=dougsland@gmail.com \
--cc=ext-Eero.Nurkkala@nokia.com \
--cc=hverkuil@xs4all.nl \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.