Re: [PATCH 1/4] always halt non-bsp cpu.

From: Gleb Natapov <gleb@redhat.com>
To: Glauber Costa <glommer@redhat.com>
Cc: kvm@vger.kernel.org, avi@redhat.com
Subject: Re: [PATCH 1/4] always halt non-bsp cpu.
Date: Wed, 3 Jun 2009 13:32:22 +0300	[thread overview]
Message-ID: <20090603103222.GA11384@redhat.com> (raw)
In-Reply-To: <1243971470-31676-2-git-send-email-glommer@redhat.com>

On Tue, Jun 02, 2009 at 03:37:47PM -0400, Glauber Costa wrote:
> This is not kvm specific, and should do fine in plain qemu
> 
> Signed-off-by: Glauber Costa <glommer@redhat.com>
> ---
>  hw/apic.c |    3 +--
>  1 files changed, 1 insertions(+), 2 deletions(-)
> 
> diff --git a/hw/apic.c b/hw/apic.c
> index 86aa6b6..2eddba0 100644
> --- a/hw/apic.c
> +++ b/hw/apic.c
> @@ -467,8 +467,7 @@ static void apic_init_ipi(APICState *s)
>  
>      cpu_reset(s->cpu_env);
>  
> -    if (!(s->apicbase & MSR_IA32_APICBASE_BSP) &&
> -        (!kvm_enabled() || !qemu_kvm_irqchip_in_kernel()))
> +    if (!(s->apicbase & MSR_IA32_APICBASE_BSP))
>          s->cpu_env->halted = 1;
>  
>      if (kvm_enabled() && !qemu_kvm_irqchip_in_kernel())
Once upon a time there was a good reason to add this: 358bdca5beb733c983bd5e7406c7893e19e9600b

What have changed?

--
			Gleb.