From: Gleb Natapov <gleb@redhat.com>
To: Avi Kivity <avi@redhat.com>
Cc: kvm@vger.kernel.org
Subject: Re: [PATCH] cleanup acpi table creation
Date: Mon, 8 Jun 2009 14:33:41 +0300 [thread overview]
Message-ID: <20090608113341.GC27210@redhat.com> (raw)
In-Reply-To: <4A2CF60C.7080807@redhat.com>
On Mon, Jun 08, 2009 at 02:29:16PM +0300, Avi Kivity wrote:
> Gleb Natapov wrote:
>> Current code is a mess. And addition of acpi tables is broken.
>>
>
> Sorry, this patch is impossible to review. Please send the shortest
> possible fix, even if it remains hacky. We'll switch to seabios as soon
> as possible, so I don't think it makes sense to clean this up.
>
seabios has the same ugly code.
--
Gleb.
prev parent reply other threads:[~2009-06-08 11:33 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-04 12:44 [PATCH] cleanup acpi table creation Gleb Natapov
2009-06-08 11:29 ` Avi Kivity
2009-06-08 11:33 ` Gleb Natapov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090608113341.GC27210@redhat.com \
--to=gleb@redhat.com \
--cc=avi@redhat.com \
--cc=kvm@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.