Re: [PATCH 1/6] env->kvm_cpu_state.init is always zero here.

From: Gleb Natapov <gleb@redhat.com>
To: Avi Kivity <avi@redhat.com>
Cc: kvm@vger.kernel.org
Subject: Re: [PATCH 1/6] env->kvm_cpu_state.init is always zero here.
Date: Mon, 15 Jun 2009 12:58:44 +0300	[thread overview]
Message-ID: <20090615095844.GJ19508@redhat.com> (raw)
In-Reply-To: <4A361A8F.8030205@redhat.com>

On Mon, Jun 15, 2009 at 12:55:27PM +0300, Avi Kivity wrote:
> On 06/14/2009 01:52 PM, Gleb Natapov wrote:
>> Signed-off-by: Gleb Natapov<gleb@redhat.com>
>> ---
>>   qemu-kvm.c |    2 +-
>>   1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> diff --git a/qemu-kvm.c b/qemu-kvm.c
>> index 2aeb17c..ec911ef 100644
>> --- a/qemu-kvm.c
>> +++ b/qemu-kvm.c
>> @@ -412,7 +412,7 @@ static int kvm_main_loop_cpu(CPUState *env)
>>   	    if (env->kvm_cpu_state.sipi_needed)
>>   	        update_regs_for_sipi(env);
>>       }
>> -	if (!env->halted&&  !env->kvm_cpu_state.init)
>> +	if (!env->halted)
>>   	    kvm_cpu_exec(env);
>>   	env->exit_request = 0;
>>           env->exception_index = EXCP_INTERRUPT;
>>    
>
> Are you sure?  Can't a reset reenable it?
>
The thing is used only with userspace irq chip. If
env->kvm_cpu_state.init == 1 update_regs_for_init() is called
three line above and it will set kvm_cpu_state.init to zero.

--
			Gleb.