All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <greg@kroah.com>
To: Tiago Vignatti <tiago.vignatti@nokia.com>
Cc: Jesse Barnes <jbarnes@virtuousgeek.org>,
	Dave Airlie <airlied@redhat.com>,
	linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] vga: implements VGA arbitration on Linux
Date: Tue, 14 Jul 2009 09:15:14 -0700	[thread overview]
Message-ID: <20090714161514.GA2026@kroah.com> (raw)
In-Reply-To: <1247576250-16274-2-git-send-email-tiago.vignatti@nokia.com>

Minor comment:

> +#ifdef DEBUG
> +	printk(KERN_DEBUG "%s\n", __func__);
> +#endif

You should just use 'dev_dbg() for any debugging statments like this.
You can turn them on and off dynamically, and you get all of the proper
device information as to what is going on automatically.

Plus, there's no need for a #ifdef in the code, which is generally
frowned apon in .c files.

thanks,

greg k-h

  parent reply	other threads:[~2009-07-14 16:15 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-07-14 12:57 [PATCH 0/2] VGA arbiter implementation Tiago Vignatti
2009-07-14 12:57 ` [PATCH 1/2] vga: implements VGA arbitration on Linux Tiago Vignatti
2009-07-14 12:57   ` [PATCH 2/2] vga: drops a documentation regarding the VGA arbiter Tiago Vignatti
2009-07-18 11:48     ` Pavel Machek
2009-07-19 18:50       ` Vignatti Tiago (Nokia-D/Helsinki)
2009-07-14 14:35   ` [PATCH 1/2] vga: implements VGA arbitration on Linux Alan Cox
2009-07-15  4:43     ` Dave Airlie
2009-07-16  4:25     ` Dave Airlie
2009-07-16  8:48       ` Alan Cox
2009-07-16 10:38         ` Dave Airlie
2009-07-16 16:25           ` Jesse Barnes
2009-07-17  0:22           ` Benjamin Herrenschmidt
2009-07-17  0:20         ` Benjamin Herrenschmidt
2009-07-17  5:00     ` Dave Airlie
2009-07-17  5:12       ` Benjamin Herrenschmidt
2009-07-14 16:15   ` Greg KH [this message]
2009-07-16  3:54     ` Dave Airlie
2009-07-16  4:02       ` Greg KH
2009-07-16  4:06         ` Dave Airlie
2009-07-16  8:41       ` Alan Cox
2009-07-17  0:24         ` Benjamin Herrenschmidt
2009-07-17  0:23       ` Benjamin Herrenschmidt
2009-07-18 11:47   ` Pavel Machek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090714161514.GA2026@kroah.com \
    --to=greg@kroah.com \
    --cc=airlied@redhat.com \
    --cc=jbarnes@virtuousgeek.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=tiago.vignatti@nokia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.