Re: [PATCH 1/3] Support for PCI Express reset type

From: Jesse Barnes <jesse.barnes@intel.com>
To: Mike Mason <mmlnx@us.ibm.com>
Cc: linuxppc-dev@ozlabs.org, Paul Mackerras <paulus@samba.org>,
	Richard Lary <rlary@us.ibm.com>,
	linux-pci@vger.kernel.org, linasvepstas@gmail.com
Subject: Re: [PATCH 1/3] Support for PCI Express reset type
Date: Fri, 14 Aug 2009 09:54:38 -0700	[thread overview]
Message-ID: <20090814095438.217810c6@jbarnes-g45> (raw)
In-Reply-To: <4A721FB1.4040903@us.ibm.com>

On Thu, 30 Jul 2009 15:33:21 -0700
Mike Mason <mmlnx@us.ibm.com> wrote:

> This is the first of three patches that implement a bit field that
> PCI Express device drivers can use to indicate they need a
> fundamental reset during error recovery.
> 
> By default, the EEH framework on powerpc does what's known as a "hot
> reset" during recovery of a PCI Express device.  We've found a case
> where the device needs a "fundamental reset" to recover properly.
> The current PCI error recovery and EEH frameworks do not support this
> distinction.
> 
> The attached patch (courtesy of Richard Lary) adds a bit field to
> pci_dev that indicates whether the device requires a fundamental
> reset during recovery.
> 
> These patches supersede the previously submitted patch that
> implemented a fundamental reset bit field. 
> 
> Please review and let me know of any concerns.
> 
> Signed-off-by: Mike Mason <mmlnx@us.ibm.com>
> Signed-off-by: Richard Lary <rlary@us.ibm.com>

Ok, applied this series to my linux-next branch, it looks pretty
reasonable to me.

For future patches, please cc me, and include the subsystem in the
subject, along with a specific description of the patch, e.g. "PCI: add
PCIe fundamental reset interface", "PCI: document PCIe fundamental
reset", or for arch specific patches, "PCI/powerpc: implement support
for PCIe fundamental reset".

Thanks,
-- 
Jesse Barnes, Intel Open Source Technology Center