From: Zhenyu Wang <zhenyuw@linux.intel.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: intel-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org,
stable@kernel.org, stern@rowland.harvard.edu
Subject: Re: [PATCH 1/3] agp/intel: remove restore in resume
Date: Fri, 11 Sep 2009 09:49:54 +0800 [thread overview]
Message-ID: <20090911014954.GB15773@zhen-devel.sh.intel.com> (raw)
In-Reply-To: <20090910182257.91c66541.akpm@linux-foundation.org>
[-- Attachment #1: Type: text/plain, Size: 1310 bytes --]
On 2009.09.10 18:22:57 -0700, Andrew Morton wrote:
>
> We still don't have a changelog for this patch which explains to the
> -stable maintainers (and those who follow -stable commits):
>
> a) what bug this patch fixes and
>
> b) why they should merge it - this should be ovbious if a) is provided.
>
> this isn't pointless paperwork - it matters to those who maintain and
> use the -stable tree. Vague references to traffic on the linux-pm list
> aren't at all useful.
Yes, thanks. I'll try to make it clear the bug it fixes.
> >From my reading of the above, it appears that Alan was experiencing
> <secretbug> and this patch was tested and fixed it, yes?
secretbug? Alan found resume hang on his 845G machine during his pm test,
and root cause that to extra pci config restore in agp/intel resume function,
which was having a fix to workaround resume order problem for host bridge and
gfx device for pci restore. But now this is handled by early pci resume already,
but the extra restore in resume caused machine hang. So remove them fixed
Alan's hang issue.
Sorry, I might misread on something, "early version merged" seems nonsense.
I'll try to send them again.
--
Open Source Technology Center, Intel ltd.
$gpg --keyserver wwwkeys.pgp.net --recv-keys 4D781827
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 197 bytes --]
prev parent reply other threads:[~2009-09-11 1:50 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-04 1:43 [PATCH 1/3] agp/intel: remove restore in resume Zhenyu Wang
2009-09-04 1:43 ` [PATCH 2/3] drm/i915: " Zhenyu Wang
2009-09-10 20:42 ` [PATCH 1/3] agp/intel: " Andrew Morton
2009-09-11 1:03 ` Zhenyu Wang
2009-09-11 1:22 ` Andrew Morton
2009-09-11 1:49 ` Zhenyu Wang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090911014954.GB15773@zhen-devel.sh.intel.com \
--to=zhenyuw@linux.intel.com \
--cc=akpm@linux-foundation.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=stable@kernel.org \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.